Skip to content

Commit f370a0b

Browse files
committed
tests changed
1 parent e45e963 commit f370a0b

File tree

2 files changed

+6
-23
lines changed

2 files changed

+6
-23
lines changed

tests/common/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ def use_group_protocol_consumer():
5656
@staticmethod
5757
def update_conf_group_protocol(conf=None):
5858
if conf is not None and 'group.id' in conf and TestUtils.use_group_protocol_consumer():
59-
if 'group.protocol' not in conf:
60-
conf['group.protocol'] = 'consumer'
59+
conf['group.protocol'] = 'consumer'
6160

6261
@staticmethod
6362
def remove_forbidden_conf_group_protocol_consumer(conf):

tests/integration/admin/test_describe_operations.py

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
ResourcePatternType, AclOperation, AclPermissionType)
2121
from confluent_kafka.error import ConsumeError
2222
from confluent_kafka import ConsumerGroupState, TopicCollection, ConsumerGroupType
23+
from tests.common import TestUtils
2324

2425
topic_prefix = "test-topic"
2526

@@ -166,7 +167,9 @@ def verify_describe_groups(cluster, admin_client, topic):
166167

167168
# Consume some messages for the group
168169
group = 'test-group'
169-
consume_messages(cluster, group, 'classic', topic, 2)
170+
group_type = ConsumerGroupType.CLASSIC if TestUtils.use_group_protocol_consumer() else ConsumerGroupType.CONSUMER
171+
group_type_str = 'classic' if group_type == ConsumerGroupType.CLASSIC else 'consumer'
172+
consume_messages(cluster, group, group_type_str, topic, 2)
170173

171174
# Verify Describe Consumer Groups
172175
desc = verify_provided_describe_for_authorized_operations(admin_client,
@@ -179,30 +182,11 @@ def verify_describe_groups(cluster, admin_client, topic):
179182
assert group == desc.group_id
180183
assert desc.is_simple_consumer_group is False
181184
assert desc.state == ConsumerGroupState.EMPTY
182-
assert desc.type == ConsumerGroupType.CLASSIC
185+
assert desc.type == group_type
183186

184187
# Delete group
185188
perform_admin_operation_sync(admin_client.delete_consumer_groups, [group], request_timeout=10)
186189

187-
consumer_group = 'test-group-consumer'
188-
189-
consume_messages(cluster, consumer_group, 'consumer', topic, 2)
190-
191-
desc = verify_provided_describe_for_authorized_operations(admin_client,
192-
admin_client.describe_consumer_groups,
193-
AclOperation.READ,
194-
AclOperation.DELETE,
195-
ResourceType.GROUP,
196-
consumer_group,
197-
[consumer_group])
198-
assert consumer_group == desc.group_id
199-
assert desc.is_simple_consumer_group is False
200-
assert desc.state == ConsumerGroupState.EMPTY
201-
assert desc.type == ConsumerGroupType.CONSUMER
202-
203-
# Delete group
204-
perform_admin_operation_sync(admin_client.delete_consumer_groups, [consumer_group], request_timeout=10)
205-
206190

207191
def verify_describe_cluster(admin_client):
208192
desc = verify_provided_describe_for_authorized_operations(admin_client,

0 commit comments

Comments
 (0)