storage: don't use stagedLayerExtract when mountLabel is set

Just be safe based on the review feedback from the PR.
#378

Signed-off-by: Paul Holzinger <[email protected]>

Author: Luap99

storage/layers.go

@@ -2526,8 +2526,7 @@ func (r *layerStore) stageWithUnlockedStore(sl *maybeStagedLayerExtraction, pare
 		cleanup, stageLayer, size, err := sl.staging.StartStagingDiffToApply(parent, drivers.ApplyDiffOpts{
 			Diff:     payload,
 			Mappings: idtools.NewIDMappingsFromMaps(layerOptions.UIDMap, layerOptions.GIDMap),
-			// FIXME: What to do here? We have no lock and assigned label yet.
-			// Overlayfs should not need it anyway so this seems fine for now.
+			// MountLabel is not supported for the unlocked extraction, see the comment in (*store).PutLayer()
 			MountLabel: "",
 		})
 		sl.cleanupFuncs = append(sl.cleanupFuncs, cleanup)

storage/store.go

@@ -1577,7 +1577,12 @@ func (s *store) PutLayer(id, parent string, names []string, mountLabel string, w
 			}
 		}()
 		// driver can do unlocked staging so do that without holding the layer lock
-		if m.staging != nil {
+		// Special case we only support it when no mount label is used. c/image doesn't set it for layers
+		// and the overlay driver doesn't use it for extract today so it would be safe even when set but
+		// that is not exactly obvious and if someone would implement the ApplyDiffStaging interface for
+		// another driver that may be no longer true. So for now simply fall back to the locked extract path
+		// to ensure we don't cause any weird issues here.
+		if m.staging != nil && mountLabel == "" {
 			// func so we have a scope for defer, we don't want to hold the lock for stageWithUnlockedStore()
 			layer, err := func() (*Layer, error) {
 				if err := rlstore.startReading(); err != nil {