aarch64: small fixes for BSD systems #477
Conversation
Apply the same hypervisor-specific correction we do for other devices. Signed-off-by: Sergio Lopez <[email protected]>
slp
requested review from
MatiasVara,
jakecorrenti,
mtjhrc and
tylerfanelli
as code owners
On aarch64, some guests use the chosen/stdout-path entry to find out the console they should use during boot. If we have a legacy serial console configure, let's create such entry to enable those guests to boot with a console. Linux guests will still switch to a virtio-console if it becomes available at some point during boot, so there isn't a risk we override that decision. Signed-off-by: Sergio Lopez <[email protected]>
We were missing registering the IrqChip on legacy serial devices, which meant they couldn't trigger IRQs. This issue went under the radar because only a few guests rely on them (so far, only NetBSD). Let's fix it here. Signed-off-by: Sergio Lopez <[email protected]>
|
It does boot fine, so that part's fixed. However, I still have the issue that ^C will terminate the whole VM. Also, ^D worked with your previous branch, now it's just literally echoed to the console and nothing happens. Maybe something to do with terminal raw mode? Arrows for navigation don't work either. |
Yes, that's because we aren't setting the raw mode for the serial device. I was planning on fixing it in a different PR, but I guess we might fix it here and now as well. |
|
Either way works for me. Thank you! |
Check if an FD being used as input for a legacy serial device is actually a tty, and if so, set raw mode for it. Signed-off-by: Sergio Lopez <[email protected]>
|
@nohajc I've added a commit setting up raw mode for legacy serial devices. Please give it a try if you have the chance. |
2 participants
This PR contains some small fixes that enable booting BSD systems on aarch64. Enables booting FreeBSD with an EDK2 firmware and smolBSD with a direct kernel boot.