Skip to content

Commit 52aec26

Browse files
committed
Minor documentation and style fixes
Signed-off-by: Mario Loriedo <[email protected]>
1 parent 6a41f20 commit 52aec26

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

docs/netavark-firewalld.7.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ There is also a dedicated firewalld driver in Netavark.
1818
This driver uses the firewalld DBus API to natively interact with firewalld.
1919
It can be enabled by setting `firewall_driver` to `firewalld` in `containers.conf`.
2020
The native firewalld driver offers better integration with firewalld, but presently suffers from several limitations.
21-
It does not support isolation (the `--opt isolate=` option to `podman network create`.
21+
It does not support isolation (the `--opt isolate=` option to `podman network create`).
2222
Connections to ports forwarded by a container on the same host can only be made through the IPv4 localhost IP (`127.0.0.1`).
2323
Using other IPs on the host will not work, unless the connection comes from a separate host.
2424

test-dhcp/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33
## Running tests
44

55
To run the tests locally in your sandbox, you can use one of these methods:
6-
* bats ./test/001-basic.bats # runs just the specified test
7-
* bats ./test/ # runs all
6+
* bats ./test-dhcp/001-basic.bats # runs just the specified test
7+
* bats ./test-dhcp/ # runs all
88

99
## Requirements
1010
- bats
1111
- jq
12+
- dnsmasq

test/200-bridge-firewalld.bats

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ function setup() {
386386
function strict_port_forwarding_enabled_should_deny_port_forwarding() {
387387
local fw_driver="$1"
388388
if [ -z "$fw_driver" ]; then
389-
echo "Error: No fw_driver provided." >&2
389+
echo "Error: No fw_driver provided." >&2
390390
return 1
391391
fi
392392

@@ -402,7 +402,7 @@ function strict_port_forwarding_enabled_should_deny_port_forwarding() {
402402
function strict_port_forwarding_disabled_should_allow_port_forwarding() {
403403
local fw_driver="$1"
404404
if [ -z "$fw_driver" ]; then
405-
echo "Error: No fw_driver provided." >&2
405+
echo "Error: No fw_driver provided." >&2
406406
return 1
407407
fi
408408

@@ -421,7 +421,7 @@ function strict_port_forwarding_disabled_should_allow_port_forwarding() {
421421
function strict_port_forwarding_invalid_value_should_warn_and_allow_port_forwarding() {
422422
local fw_driver="$1"
423423
if [ -z "$fw_driver" ]; then
424-
echo "Error: No fw_driver provided." >&2
424+
echo "Error: No fw_driver provided." >&2
425425
return 1
426426
fi
427427

0 commit comments

Comments
 (0)