Merge pull request #196 from cdoern/login

podman-py login support

Author: rhatdan

podman/domain/system.py

@@ -3,6 +3,7 @@
 from typing import Any, Dict, Optional
 
 from podman.api.client import APIClient
+from podman import api
 
 logger = logging.getLogger("podman.system")
 
@@ -40,8 +41,8 @@ def login(
         password: Optional[str] = None,
         email: Optional[str] = None,
         registry: Optional[str] = None,
-        reauth: bool = False,
-        dockercfg_path: Optional[str] = None,
+        reauth: Optional[bool] = False,  # pylint: disable=unused-argument
+        dockercfg_path: Optional[str] = None,  # pylint: disable=unused-argument
     ) -> Dict[str, Any]:
         """Log into Podman service.
 
@@ -50,12 +51,27 @@ def login(
             password: Registry plaintext password
             email: Registry account email address
             registry: URL for registry access. For example,
+            reauth: Ignored: If True, refresh existing authentication. Default: False
+            dockercfg_path: Ignored: Path to custom configuration file.
                 https://quay.io/v2
-            reauth: If True, refresh existing authentication. Default: False
-            dockercfg_path: Path to custom configuration file.
-                Default: $HOME/.config/containers/config.json
         """
 
+        payload = {
+            "username": username,
+            "password": password,
+            "email": email,
+            "serveraddress": registry,
+        }
+        payload = api.prepare_body(payload)
+        response = self.client.post(
+            path="/auth",
+            headers={"Content-type": "application/json"},
+            data=payload,
+            compatible=True,
+        )
+        response.raise_for_status()
+        return response.json()
+
     def ping(self) -> bool:
         """Returns True if service responded with OK."""
         response = self.client.head("/_ping")

podman/tests/integration/test_system.py

@@ -16,6 +16,7 @@
 
 import podman.tests.integration.base as base
 from podman import PodmanClient
+from podman.errors import APIError
 
 
 class SystemIntegrationTest(base.IntegrationTest):
@@ -44,3 +45,15 @@ def test_show_disk_usage(self):
         self.assertTrue('Images' in output)
         self.assertTrue('Containers' in output)
         self.assertTrue('Volumes' in output)
+
+    def test_login(self):
+        """integration: system login call"""
+        # here, we just test the sanity of the endpoint
+        # confirming that we get through to podman, and get tcp rejected.
+        with self.assertRaises(APIError) as e:
+            next(
+                self.client.login(
+                    "fake_user", "fake_password", "fake_email@fake_domain.test", "fake_registry"
+                )
+            )
+        self.assertIn("lookup fake_registry: no such host", e.exception.explanation)