Stat Identity file on sys con add

Fixes: #26016

Signed-off-by: Nicola Sella <[email protected]>

Author: inknos

cmd/podman/system/connection/add.go

@@ -141,6 +141,11 @@ func add(cmd *cobra.Command, args []string) error {
 
 	switch uri.Scheme {
 	case "ssh":
+		if cOpts.Identity != "" {
+			if _, err := os.Stat(cOpts.Identity); errors.Is(err, os.ErrNotExist) {
+				return fmt.Errorf("identity file does not exist: %s", cOpts.Identity)
+			}
+		}
 		return ssh.Create(entities, sshMode)
 	case "unix":
 		if cmd.Flags().Changed("identity") {

test/system/272-system-connection.bats

@@ -88,6 +88,28 @@ $c2[ ]\+tcp://localhost:54321[ ]\+true[ ]\+true" \
     run_podman context rm $c1
 }
 
+# Test system connection add bad identities with ssh/unix/tcp
+@test "podman system connection --identity" {
+    run_podman system connection ls
+    is "$output" "Name        URI         Identity    Default     ReadWrite" \
+       "system connection ls: no connections"
+
+    run_podman system connection add ssh-conn --identity ~/nonexistent ssh://localhost
+    is "$output" \
+        "Error: idendity file does not exist: ~/nonexistent"
+    run_podman system connection add unix-conn --identity ~/identity unix://path
+    is "$output"\
+        "Error: --identity option not supported for unix scheme"
+    run_podman system connection add tcp-conn --identity ~/identity tcp://path
+    is "$output"\
+        "Error: --identity option not supported for unix scheme"
+
+    # Ensure no connections were added
+    run_podman system connection ls
+    is "$output" "Name        URI         Identity    Default     ReadWrite" \
+       "system connection ls: no connections"
+}
+
 # Test tcp socket; requires starting a local server
 @test "podman system connection - tcp" {
     # Start server