Print error message when UID or GID mapping failed

Fak3 · Fak3 · commit 1bbeb127b940 · 2025-01-30T21:28:00.000+05:00
Refs containers/crun#1648 Signed-off-by: Evstifeev Roman <someuniquename@gmail.com>
diff --git a/pkg/idtools/idtools.go b/pkg/idtools/idtools.go
@@ -89,6 +89,7 @@ func GetRootUIDGID(uidMap, gidMap []IDMap) (int, int, error) {
 	} else {
 		uid, err = RawToHost(0, uidMap)
 		if err != nil {
+			logrus.Errorf("Container uses userid mappings, but does not map UID 0 (root)")
 			return -1, -1, err
 		}
 	}
@@ -97,6 +98,7 @@ func GetRootUIDGID(uidMap, gidMap []IDMap) (int, int, error) {
 	} else {
 		gid, err = RawToHost(0, gidMap)
 		if err != nil {
+			logrus.Errorf("Container uses groupid mappings, but does not map GID 0 (root)")
 			return -1, -1, err
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,7 @@ func GetRootUIDGID(uidMap, gidMap []IDMap) (int, int, error) {`
`89`	`89`	`} else {`
`90`	`90`	`uid, err = RawToHost(0, uidMap)`
`91`	`91`	`if err != nil {`
	`92`	`+ logrus.Errorf("Container uses userid mappings, but does not map UID 0 (root)")`
`92`	`93`	`return -1, -1, err`
`93`	`94`	`}`
`94`	`95`	`}`
`@@ -97,6 +98,7 @@ func GetRootUIDGID(uidMap, gidMap []IDMap) (int, int, error) {`
`97`	`98`	`} else {`
`98`	`99`	`gid, err = RawToHost(0, gidMap)`
`99`	`100`	`if err != nil {`
	`101`	`+ logrus.Errorf("Container uses groupid mappings, but does not map GID 0 (root)")`
`100`	`102`	`return -1, -1, err`
`101`	`103`	`}`
`102`	`104`	`}`