Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archive.TarWithOptions swallows error #2243

Open
hanwen-flow opened this issue Feb 3, 2025 · 0 comments
Open

archive.TarWithOptions swallows error #2243

hanwen-flow opened this issue Feb 3, 2025 · 0 comments

Comments

@hanwen-flow
Copy link
Contributor

See https://github.com/containers/storage/blob/main/pkg/archive/archive.go#L1005

If something went wrong (eg. I/O error), this code happily continues. This has the potential to silently introduce corruption in applications of tar streams (eg. images, copies, snapshots etc.).
hanwen-flow added a commit to hanwen-flow/containers-storage that referenced this issue Feb 18, 2025
@hanwen-flow
pkg/archive: make tar write failures fatal
f204616 
Previously, these would be swallowed, which runs the risk of
generating corrupted archives.

Fixes containers#2243

Signed-off-by: Han-Wen Nienhuys <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hanwen-flow