Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in UI Module #141

Open
himanshu2047 opened this issue Dec 1, 2020 · 3 comments
Open

Bugs in UI Module #141

himanshu2047 opened this issue Dec 1, 2020 · 3 comments

Comments

@himanshu2047
Copy link
Contributor

himanshu2047 commented Dec 1, 2020

There are some bugs noticed during the server testing -

  1. You are first calling initialise of Processing and Content Module and after that you are initialising your own canvas and everything else, instead you should do the opposite.
  2. There is an error while we are providing the changes to UI, which is NULLPointerException in UI.CanvasController.updateChanges()
  3. You should display the BoardID on the UI somewhere, so that while testing we can know which board they need to connect and generally as well.
  4. Suggestion to make the default color black instead of white as usually the user will start drawing first instead of changing the color and when the color is white he/she will not be able to see anything.

@sai-deekshith16

@sai-deekshith16
Copy link
Contributor

In the above mentioned bugs all of them are resolved in the last PR except changing the default colour in the colour picker as black. We tried to change it but were not able to.

@convict-git
Copy link
Owner

In the above mentioned bugs all of them are resolved in the last PR except changing the default colour in the colour picker as black. We tried to change it but were not able to.

Can you open a new issue for it? So I can close this.

@sai-deekshith16
Copy link
Contributor

In the above mentioned bugs all of them are resolved in the last PR except changing the default colour in the colour picker as black. We tried to change it but were not able to.

Can you open a new issue for it? So I can close this.

I opened a new issue for the colour picker. You can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants