Merge pull request #62 from sbsurf/master

Allowing for custom setting of maxPendingRequests.

Author: jlbooker

src/bloodhound/remote.js

@@ -19,7 +19,8 @@ var Remote = (function() {
     this.transport = new Transport({
       cache: o.cache,
       limiter: o.limiter,
-      transport: o.transport
+      transport: o.transport,
+      maxPendingRequests: o.maxPendingRequests
     });
   }
 

src/bloodhound/transport.js

@@ -9,7 +9,6 @@ var Transport = (function() {
 
   var pendingRequestsCount = 0,
       pendingRequests = {},
-      maxPendingRequests = 6,
       sharedCache = new LruCache(10);
 
   // constructor
@@ -18,6 +17,7 @@ var Transport = (function() {
   function Transport(o) {
     o = o || {};
 
+    this.maxPendingRequests = o.maxPendingRequests || 6;
     this.cancelled = false;
     this.lastReq = null;
 
@@ -31,7 +31,7 @@ var Transport = (function() {
   // --------------
 
   Transport.setMaxPendingRequests = function setMaxPendingRequests(num) {
-    maxPendingRequests = num;
+    this.maxPendingRequests = num;
   };
 
   Transport.resetCache = function resetCache() {
@@ -65,7 +65,7 @@ var Transport = (function() {
       }
 
       // under the pending request threshold, so fire off a request
-      else if (pendingRequestsCount < maxPendingRequests) {
+      else if (pendingRequestsCount < this.maxPendingRequests) {
         pendingRequestsCount++;
         pendingRequests[fingerprint] =
           this._send(o).done(done).fail(fail).always(always);

test/bloodhound/transport_spec.js

@@ -32,7 +32,17 @@ describe('Transport', function() {
     expect(spy).toHaveBeenCalledWith(null, resp.parsed);
   });
 
-  it('should respect maxPendingRequests configuration', function() {
+  it('should use maxPendingRequests configuration option', function() {
+    this.transport = new Transport({ transport: $.ajax, maxPendingRequests: 2 });
+
+    for (var i = 0; i < 5; i++) {
+      this.transport.get('/test' + i, $.noop);
+    }
+
+    expect(ajaxRequests.length).toBe(2);
+  });
+
+  it('should open up to 6 maxPendingRequests by default', function() {
     for (var i = 0; i < 10; i++) {
       this.transport.get('/test' + i, $.noop);
     }