Skip to content

fix(googledrive): forward query params on non-GET requests #589

Description

@ambikeesshh

makeGoogleDriveRequest only sends query for GET:

query: method === 'GET' ? query : undefined,

Endpoints still pass query on POST/PATCH/DELETE for things like uploadType, addParents / removeParents, and supportsAllDrives. Those get stripped, so uploads and parent moves can silently miss required params.

Fix

Forward query for all methods, or at least for the mutating calls that need it.

Check

  • POST upload keeps uploadType
  • PATCH move keeps addParents / removeParents
  • DELETE still forwards supportsAllDrives when provided
  • unit test asserting query on a non-GET call
pnpm --filter @corsair-dev/googledrive test

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdifficulty: easySmall scoped fixgood first issueGood for newcomerspluginChanges inside a plugin package

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions