Skip to content

Commit a592358

Browse files
committed
Removed dependency; proper fix for #43
1 parent 853883f commit a592358

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

package-lock.json

-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
},
3232
"devDependencies": {
3333
"chai": "^4.2.0",
34-
"chai-spies": "^1.0.0",
3534
"fake-timers": "^0.1.2",
3635
"mocha": "^8.2.0",
3736
"nock": "^13.0.4",

serve.js

+7-3
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,13 @@ srv.post('/github', async (req, res, next) => {
105105
console.log('Post received')
106106
let id = req.header('x-github-hook-installation-target-id');
107107
if (id != process.env.GITHUB_APP_IDENTIFIER) { next(); return; } // Not for us; move on
108-
await setAccessToken();
109-
log.extend('event')('X-GitHub-Event: %s', req.header('X-GitHub-Event'));
110-
handler(req, res, () => res.end('ok'));
108+
if (req.header('X-GitHub-Event') in supportedEvents) {
109+
await setAccessToken();
110+
handler(req, res, () => res.end('ok'));
111+
} else {
112+
log('GitHub Event "%s" not supported', req.header('X-GitHub-Event'));
113+
res.sendStatus(400);
114+
}
111115
});
112116

113117

0 commit comments

Comments
 (0)