Skip to content

DataHash is used but not set on sdk v0.50 for ica account creation #8211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
4 tasks
damiannolan opened this issue Mar 24, 2025 · 1 comment · May be fixed by #8307
Open
4 tasks

DataHash is used but not set on sdk v0.50 for ica account creation #8211

damiannolan opened this issue Mar 24, 2025 · 1 comment · May be fixed by #8307

Comments

@damiannolan
Copy link
Contributor

Summary

Interchain accounts uses DataHash as a source of entropy for account creation.
See https://github.com/cosmos/ibc-go/blob/main/modules/apps/27-interchain-accounts/types/account.go#L52

This field is not set in the header in cosmos-sdk v0.50 and above.
https://github.com/cosmos/cosmos-sdk/blob/v0.50.13/baseapp/abci.go#L709-L716

AppHash should still be fine here. Just wanted to notify about this.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@gjermundgaraba
Copy link
Contributor

That is a good point. If AppHash is enough we can probably just get rid of that line to avoid confusion?

@gjermundgaraba gjermundgaraba linked a pull request Apr 15, 2025 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove datahash from ica account creation cosmos/ibc-go
2 participants
@gjermundgaraba @damiannolan