TWIN refuses to compile on Fedora 41

[SwirlyStone5877]

This is the entire log when I run make after running config and installing necessary dependencies.

make
Making all in docs
make[1]: Entering directory '/home/jack/twin/docs'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/jack/twin/docs'
Making all in include
make[1]: Entering directory '/home/jack/twin/include'
make  all-recursive
make[2]: Entering directory '/home/jack/twin/include'
Making all in Tutf
make[3]: Entering directory '/home/jack/twin/include/Tutf'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/home/jack/twin/include/Tutf'
Making all in Tw
make[3]: Entering directory '/home/jack/twin/include/Tw'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/home/jack/twin/include/Tw'
make[3]: Entering directory '/home/jack/twin/include'
make[3]: Leaving directory '/home/jack/twin/include'
make[2]: Leaving directory '/home/jack/twin/include'
make[1]: Leaving directory '/home/jack/twin/include'
Making all in libs
make[1]: Entering directory '/home/jack/twin/libs'
Making all in libtstl
make[2]: Entering directory '/home/jack/twin/libs/libtstl'
source='utf8.cpp' object='utf8.lo' libtool=yes \
DEPDIR=.deps depmode=none /bin/sh ../../admin/depcomp \
/bin/sh ../../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I../../include  -I../../include    -c -o utf8.lo utf8.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../include -I../../include -c utf8.cpp  -o .libs/utf8.o
utf8.cpp:61:8: error: no declaration matches ‘unsigned int Utf8::to_size(seq)’
   61 | size_t Utf8::to_size(seq x) NOTHROW {
      |        ^~~~
In file included from utf8.cpp:9:
../../include/stl/utf8.h:29:17: note: candidate is: ‘static size_t Utf8::to_size(seq)’
   29 |   static size_t to_size(seq x) NOTHROW;
      |                 ^~~~~~~
../../include/stl/utf8.h:20:7: note: ‘class Utf8’ defined here
   20 | class Utf8 {
      |       ^~~~
utf8.cpp:61:22: error: ‘union Utf8::seq’ is private within this context
   61 | size_t Utf8::to_size(seq x) NOTHROW {
      |                      ^~~
../../include/stl/utf8.h:22:9: note: declared private here
   22 |   union seq {
      |         ^~~
utf8.cpp:75:7: error: no declaration matches ‘Chars Utf8::chars()’
   75 | Chars Utf8::chars() const NOTHROW {
      |       ^~~~
../../include/stl/utf8.h:69:9: note: candidate is: ‘Chars Utf8::chars() const’
   69 |   Chars chars() const NOTHROW;
      |         ^~~~~
../../include/stl/utf8.h:20:7: note: ‘class Utf8’ defined here
   20 | class Utf8 {
      |       ^~~~
utf8.cpp: In member function ‘bool Utf8::parse(Chars, Chars*)’:
utf8.cpp:81:31: error: invalid conversion from ‘const char*’ to ‘char*’ [-fpermissive]
   81 |   const char *src = chars.data();
      |                     ~~~~~~~~~~^~
      |                               |
      |                               const char*
utf8.cpp: In static member function ‘static bool Utf8::less(seq, seq)’:
utf8.cpp:134:10: error: ‘htonl’ was not declared in this scope
  134 |   return htonl(x.val) < htonl(y.val);
      |          ^~~~~
make[2]: *** [Makefile:501: utf8.lo] Error 1
make[2]: Leaving directory '/home/jack/twin/libs/libtstl'
make[1]: *** [Makefile:406: all-recursive] Error 1
make[1]: Leaving directory '/home/jack/twin/libs'
make: *** [Makefile:518: all-recursive] Error 1

I don't know what to do at the moment. Any help would be appreciated.

[cosmos72]

Hi @SwirlyStone5877,
the errors you reported are really strange.

For example

utf8.cpp:61:22: error: ‘union Utf8::seq’ is private within this context

should really not happen when compiling the method Utf8::to_size(), which clearly has access to private declarations of its own class.

Even more strange is the error

utf8.cpp:81:31: error: invalid conversion from ‘const char*’ to ‘char*’ [-fpermissive]

where the relevant line (also quoted in your report) is

81 |   const char *src = chars.data();

thus there is a conversion to const char *, not to char *.

I don't have a Fedora installation available at the moment,
so I can offer only workarounds:

1. try with a different g++ version
2. try using clang and clang++ instead of gcc and g++, for example with ./configure CC=clang-SOME-VERSION CXX=clang-SOME-VERSION where of course SOME-VERSION must be replaced with the clang version you install or already have

[SwirlyStone5877]

Hi @SwirlyStone5877,
the errors you reported are really strange.

For example

utf8.cpp:61:22: error: ‘union Utf8::seq’ is private within this context

should really not happen when compiling the method Utf8::to_size(), which clearly has access to private declarations of its own class.

Even more strange is the error

utf8.cpp:81:31: error: invalid conversion from ‘const char*’ to ‘char*’ [-fpermissive]

where the relevant line (also quoted in your report) is

81 |   const char *src = chars.data();

thus there is a conversion to const char *, not to char *.

I don't have a Fedora installation available at the moment,
so I can offer only workarounds:

1. try with a different g++ version
2. try using clang and clang++ instead of gcc and g++, for example with ./configure CC=clang-SOME-VERSION CXX=clang-SOME-VERSION where of course SOME-VERSION must be replaced with the clang version you install or already have

Alright, I'll try this when I get a chance. Thanks! :D

[SwirlyStone5877]

...Uh...
I can't try the fix.
Long story short, the internal HDD in the PC managed to die before I could try your fix.
I no longer have a working Fedora installation...yippee...

[vmisev]

With changes to the 'contrib/twin.spec' I proposed in cosmos72/twin/pull/103 rpmbuild on Fedora 41 compiles everything without any errors.
Relevant part of the build log:

Making all in libs
make[1]: Entering directory '/home/vmisev/rpmbuild/BUILD/twin-0.9.1+git-build/twin-0.9.1+git/libs'
Making all in libtstl
make[2]: Entering directory '/home/vmisev/rpmbuild/BUILD/twin-0.9.1+git-build/twin-0.9.1+git/libs/libtstl'

# ...
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../include -I../../include -O2 -g -ffat-lto-objects -std=c++98 -fomit-frame-pointer -fno-strict-aliasing -pipe -Wall -Wshadow -Wno-uninitialized -Wno-unused -Wundef -Wcast-qual -Wcast-align -Wpointer-arith -Wwrite-strings -MT to_chars.lo -MD -MP -MF .deps/to_chars.Tpo -c to_chars.cpp  -fPIC -DPIC -o .libs/to_chars.o
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../include -I../../include -O2 -g -ffat-lto-objects -std=c++98 -fomit-frame-pointer -fno-strict-aliasing -pipe -Wall -Wshadow -Wno-uninitialized -Wno-unused -Wundef -Wcast-qual -Wcast-align -Wpointer-arith -Wwrite-strings -MT to_chars.lo -MD -MP -MF .deps/to_chars.Tpo -c to_chars.cpp -fPIE -o to_chars.o >/dev/null 2>&1
depbase=`echo utf8.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/sh ../../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I../../include  -I../../include   -O2 -g -ffat-lto-objects -fPIE  -std=c++98 -fomit-frame-pointer -fno-strict-aliasing -pipe -Wall -Wshadow -Wno-uninitialized -Wno-unused -Wundef -Wcast-qual -Wcast-align -Wpointer-arith -Wwrite-strings -MT utf8.lo -MD -MP -MF $depbase.Tpo -c -o utf8.lo utf8.cpp &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../include -I../../include -O2 -g -ffat-lto-objects -std=c++98 -fomit-frame-pointer -fno-strict-aliasing -pipe -Wall -Wshadow -Wno-uninitialized -Wno-unused -Wundef -Wcast-qual -Wcast-align -Wpointer-arith -Wwrite-strings -MT utf8.lo -MD -MP -MF .deps/utf8.Tpo -c utf8.cpp  -fPIC -DPIC -o .libs/utf8.o
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../include -I../../include -O2 -g -ffat-lto-objects -std=c++98 -fomit-frame-pointer -fno-strict-aliasing -pipe -Wall -Wshadow -Wno-uninitialized -Wno-unused -Wundef -Wcast-qual -Wcast-align -Wpointer-arith -Wwrite-strings -MT utf8.lo -MD -MP -MF .deps/utf8.Tpo -c utf8.cpp -fPIE -o utf8.o >/dev/null 2>&1
/bin/sh ../../libtool  --tag=CXX   --mode=link g++  -O2 -g -ffat-lto-objects -fPIE  -std=c++98 -fomit-frame-pointer -fno-strict-aliasing -pipe -Wall -Wshadow -Wno-uninitialized -Wno-unused -Wundef -Wcast-qual -Wcast-align -Wpointer-arith -Wwrite-strings -version-info 2:0:1 -no-undefined -Wl,-z,relro -Wl,--as-needed  -Wl,-z,pack-relative-relocs -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes  -o libtstl.la -rpath /usr/lib64 alloc.lo chars.lo err.lo fmt.lo string.lo to_chars.lo utf8.lo
libtool: link: g++  -fPIC -DPIC -shared -nostdlib /usr/lib/gcc/x86_64-redhat-linux/14/../../../../lib64/crti.o /usr/lib/gcc/x86_64-redhat-linux/14/crtbeginS.o  .libs/alloc.o .libs/chars.o .libs/err.o .libs/fmt.o .libs/string.o .libs/to_chars.o .libs/utf8.o   -L/usr/lib/gcc/x86_64-redhat-linux/14 -L/usr/lib/gcc/x86_64-redhat-linux/14/../../../../lib64 -L/lib/../lib64 -L/usr/lib/../lib64 -L/usr/lib/gcc/x86_64-redhat-linux/14/../../.. -lstdc++ -lm -lc -lgcc_s /usr/lib/gcc/x86_64-redhat-linux/14/crtendS.o /usr/lib/gcc/x86_64-redhat-linux/14/../../../../lib64/crtn.o -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -O2 -g -Wl,-z -Wl,relro -Wl,--as-needed -Wl,-z -Wl,pack-relative-relocs -Wl,-z -Wl,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes   -Wl,-soname -Wl,libtstl.so.1 -o .libs/libtstl.so.1.1.0
libtool: link: (cd ".libs" && rm -f "libtstl.so.1" && ln -s "libtstl.so.1.1.0" "libtstl.so.1")
libtool: link: (cd ".libs" && rm -f "libtstl.so" && ln -s "libtstl.so.1.1.0" "libtstl.so")
libtool: link: ar cr .libs/libtstl.a  alloc.o chars.o err.o fmt.o string.o to_chars.o utf8.o
libtool: link: ranlib .libs/libtstl.a
libtool: link: ( cd ".libs" && rm -f "libtstl.la" && ln -s "../libtstl.la" "libtstl.la" )
make[2]: Leaving directory '/home/vmisev/rpmbuild/BUILD/twin-0.9.1+git-build/twin-0.9.1+git/libs/libtstl'