Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Extract i18n service API into separate module #14

Open
jasnell opened this issue Jul 31, 2020 · 2 comments
Open

TODO: Extract i18n service API into separate module #14

jasnell opened this issue Jul 31, 2020 · 2 comments

Comments

@jasnell
Copy link
Contributor

jasnell commented Jul 31, 2020

https://github.com/covidgreen/covid-green-app/tree/current/services/i18n contains common i18n code to support the application. To help maintain that code and limit the possibility of region-specific variations from cropping up, that should be extracted into its own standalone module.

@ShaunBaker
Copy link
Contributor

As an app developer who desires to fork CGA to create an app for an authority with this proposal I would also need to fork the i18n module, change references in the app to the fork etc in order to continue.

For something that has a small implementation, and is required within the app itself in order for it to work I'm not sure I agree the overheads stated above make this worthwhile. Im not clear on the merit of this proposed change.

cc @jasnell

@jasnell
Copy link
Contributor Author

jasnell commented Aug 6, 2020

Consider this a low priority. Looking across the variations, there is enough similarity between them to warrant separating this out, but I wouldn't consider it a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants