Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue: Localization Guide #8

Open
jasnell opened this issue Jul 22, 2020 · 4 comments
Open

Tracking Issue: Localization Guide #8

jasnell opened this issue Jul 22, 2020 · 4 comments

Comments

@jasnell
Copy link
Contributor

jasnell commented Jul 22, 2020

As part of the documentation for the application, it would be ideal to have a quick guide on how to start localizing the application

@svekeman
Copy link

Yes! We have started the process to translate into Dutch.

@rgcamus
Copy link

rgcamus commented Jul 24, 2020

I've already done a Spanish translation. You can see the small changes needed in this commit

As far as I know there are only two things to do:

  1. Create a new messages file: You must use the original assests/lang/en.json as a template. I think you should name it, in the same directory, after the standardized nomenclature used to classify languages
  2. Add the references to that file in services/i18n/common.tsx.

@jasnell
Copy link
Contributor Author

jasnell commented Jul 24, 2020

I believe the messages file and the references are only part of it. There are, of course, the various graphical elements, support for right-to-left languages, etc. To this point the team has been focused strictly on the immediate practical needs of getting things working. It would be helpful to have someone do an audit from an i18n/l11n perspective and start collecting the list of issues/requirements.

@rgcamus
Copy link

rgcamus commented Jul 24, 2020

I believe the messages file and the references are only part of it. There are, of course, the various graphical elements, support for right-to-left languages, etc. To this point the team has been focused strictly on the immediate practical needs of getting things working. It would be helpful to have someone do an audit from an i18n/l11n perspective and start collecting the list of issues/requirements.

You're right. For the record:

  • app/assets/localities.ts contains the geographic distribution of Ireland. Perhaps it should be named after https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes. app/assets/localities.ie.ts? . It's referenced in app/components/molecules/locality-dropdown.tsx
  • app/assets/country-codes.ts is not localized.

I think i18next supports RTL out of the box (I have no experience there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants