body_read_stream implementation (replacement for PR 57) #78
Conversation
|
An automated preview of the documentation is available at https://78.beast2.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2025-11-12 14:00:44 UTC |
MungoG
changed the title
| auto lambda2 = [&](system::error_code ec, std::size_t n) | ||
| { | ||
| BOOST_TEST_EQ(n, 0); | ||
| BOOST_TEST_EQ(ec, http_proto::error::incomplete); |
There was a problem hiding this comment.
Could you please explain why the second handler is expected to always complete with error::incomplete?
There was a problem hiding this comment.
This is because, after a cancellation, the test stream fires an initial operation_aborted callback, and thereafter any attempt to async_read from that previously cancelled test stream gives an eof callback.
This eof causes beast2::async_read_some to call pr_.commit_eof, as a result of which the parser's parse call returns error::incomplete.
There was a problem hiding this comment.
The behavior of test::stream is wrong then, it should just cancel the existing operation.
There was a problem hiding this comment.
@MungoG I'm working on a fix for test::stream cancellation. It should be merged within a couple of hours.
MungoG
force-pushed
the
issue-55-async-body-stream-impl-v3
branch
from
2ca95d9 to
b7afa53
Compare
MungoG
force-pushed
the
issue-55-async-body-stream-impl-v3
branch
from
b7afa53 to
7b71549
Compare
3 participants
This is a replacement PR for #57 as the source branch had to be recreated.