Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngShow / ngHide Classes Get Applied In The $$postDigest Phase Caused confirm box height error #14

Open
Woodu opened this issue May 26, 2017 · 1 comment

Comments

@Woodu
Copy link

Woodu commented May 26, 2017

Hi,
I'm using angular 1.5.9 and angular-confirm 1.1.0.

Due to this article:
https://www.bennadel.com/blog/2853-ngshow-nghide-classes-get-applied-in-the-postdigest-phase-in-angularjs-1-3.htm
If I use dom controller with ng-hide or ng-show in confirm box template, the digest will first update confirm box height, then the dom get updated.
so I changed some code on line 913~917 :

var thisBox = this;
          $timeout(function asyncTestCheck(){
            console.log($content.outerHeight());
            thisBox.$contentPane.css({
              'height': $content.outerHeight(),
            }).scrollTop(0);
            thisBox.$confirmBox.css(style);
          },0,false);

As a walkaround, I doesnt changed the calculate of contentHeight. Maybe could get fixed in next version.

@craftpip
Copy link
Owner

Thanks @Woodu for the idea, i will work on a reliable fix to this
Your support is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants