From 2dd17f99fb6944ecf01c3977f3ca9dd05a085a0e Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Thu, 5 Jun 2025 18:15:12 +0200 Subject: [PATCH 1/3] main: Change some logs from Info to Debug They are dumping some internal data structures using %+v which is not very user friendly. Signed-off-by: Christophe Fergeau --- cmd/vfkit/main.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/vfkit/main.go b/cmd/vfkit/main.go index 288c4a4d..c0587e07 100644 --- a/cmd/vfkit/main.go +++ b/cmd/vfkit/main.go @@ -72,8 +72,8 @@ func newVMConfiguration(opts *cmdline.Options) (*config.VirtualMachine, error) { return nil, err } - log.Info(opts) - log.Infof("boot parameters: %+v", bootloader) + log.Debugf("parsed options: %+v", opts) + log.Debugf("boot parameters: %+v", bootloader) log.Info() vmConfig := config.NewVirtualMachine( From 9972181d1b018d68562c7dc214a6a6a9f024161b Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Thu, 5 Jun 2025 18:17:03 +0200 Subject: [PATCH 2/3] =?UTF-8?q?start-gvproxy:=E2=80=AFUse=20consistent=20-?= =?UTF-8?q?-=20/=20-=20prefix=20for=20options?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Christophe Fergeau --- contrib/scripts/start-gvproxy.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/scripts/start-gvproxy.sh b/contrib/scripts/start-gvproxy.sh index 70706c31..56156244 100755 --- a/contrib/scripts/start-gvproxy.sh +++ b/contrib/scripts/start-gvproxy.sh @@ -23,7 +23,7 @@ set -exuo pipefail DISK_IMAGE="${1?Usage: $0 diskimage}" VM_NAME="$(basename ${DISK_IMAGE})" -${GVPROXY} -mtu 1500 -ssh-port 2223 -listen-vfkit unixgram://$(pwd)/${VM_NAME}.sock -log-file ${VM_NAME}.gvproxy.log --pid-file ${VM_NAME}.gvproxy.pid & +${GVPROXY} --mtu 1500 --ssh-port 2223 --listen-vfkit unixgram://$(pwd)/${VM_NAME}.sock --log-file ${VM_NAME}.gvproxy.log --pid-file ${VM_NAME}.gvproxy.pid & TO_REMOVE="${VM_NAME}.sock ${VM_NAME}.gvproxy.pid ${VM_NAME}.overlay.img ${VM_NAME}.efistore.nvram" trap 'if [[ -f "${VM_NAME}.gvproxy.pid" ]]; then kill $(cat ${VM_NAME}.gvproxy.pid); fi; rm -f ${TO_REMOVE}' EXIT From 10cf933936234b67a1cc63cd906980e82c35fb6a Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Thu, 5 Jun 2025 18:15:12 +0200 Subject: [PATCH 3/3] doc: Fix documentation of --restful-uri default value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit By default it’s set to `none://`: ``` pkg/cmdline/cmdline.go:const DefaultRestfulURI = "none://" ``` Signed-off-by: Christophe Fergeau --- doc/usage.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/usage.md b/doc/usage.md index 8ffbf77d..6bbab368 100644 --- a/doc/usage.md +++ b/doc/usage.md @@ -15,7 +15,7 @@ Set the log-level for VFKit. Supported values are `debug`, `info`, and `error`. - `--restful-uri` -The URI (address) of the RESTful service. The default is `tcp://localhost:8081`. Valid schemes are +The URI (address) of the RESTful service. By default it’s disabled. Valid schemes are `tcp`, `none`, or `unix`. In the case of unix, the "host" portion would be a path to where the unix domain socket will be stored. A scheme of `none` disables the RESTful service. ### Virtual Machine Resources