refactor: move defaults to a const

Author: crccheck

django_object_actions/tests/tests.py

@@ -46,7 +46,6 @@ def test_can_return_template(self):
         # it's good to document that this is something we can do.
         url = reverse("admin:polls_poll_actions", args=(1, "delete_all_choices"))
         response = self.client.get(url)
-        print(url, response)
         self.assertTemplateUsed(response, "clear_choices.html")
 
     def test_message_user_sends_message(self):

django_object_actions/utils.py

@@ -11,6 +11,9 @@
 from django.views.generic.list import MultipleObjectMixin
 from django.urls import re_path, reverse
 
+DEFAULT_METHODS_ALLOWED = ("GET", "POST")
+DEFAULT_BUTTON_TYPE = "a"
+
 
 class BaseDjangoObjectActions(object):
     """
@@ -159,7 +162,7 @@ def _get_tool_dict(self, tool_name):
             label=getattr(tool, "label", tool_name.replace("_", " ").capitalize()),
             standard_attrs=standard_attrs,
             custom_attrs=custom_attrs,
-            button_type=getattr(tool, "button_type", "a"),
+            button_type=getattr(tool, "button_type", DEFAULT_BUTTON_TYPE),
         )
 
     def _get_button_attrs(self, tool):
@@ -249,9 +252,7 @@ def dispatch(self, request, tool, **kwargs):
         except KeyError:
             raise Http404("Action does not exist")
 
-        # TODO move ('get', 'post' config default someplace else)
-        allowed_methods = getattr(view, "methods", ("GET", "POST"))
-        print("dispatch", request.method, allowed_methods)
+        allowed_methods = getattr(view, "methods", DEFAULT_METHODS_ALLOWED)
         if request.method.upper() not in allowed_methods:
             return HttpResponseNotAllowed(allowed_methods)
 
@@ -324,8 +325,8 @@ def action(
     description=None,
     label=None,
     attrs=None,
-    methods=("GET", "POST"),
-    button_type="a",
+    methods=DEFAULT_METHODS_ALLOWED,
+    button_type=DEFAULT_BUTTON_TYPE,
 ):
     """
     Conveniently add attributes to an action function: