Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]Header and Input Styling Not Aligning with vocabulary #322

Open
1 task done
Queen-codes opened this issue Feb 5, 2025 · 3 comments · May be fixed by #324
Open
1 task done

[Feature]Header and Input Styling Not Aligning with vocabulary #322

Queen-codes opened this issue Feb 5, 2025 · 3 comments · May be fixed by #324
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@Queen-codes
Copy link
Contributor

Problem

The header and input field in the search portal website slightly differ from the search-index context in the vocabulary design system.

Description

The header and input field should match the design system specifications for consistent styling.

Implementation

  • I would be interested in implementing this feature.
@Queen-codes Queen-codes added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Feb 5, 2025
@TimidRobot TimidRobot added 🏁 status: ready for work Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Feb 5, 2025
@TimidRobot TimidRobot moved this to Backlog in possumbilities Feb 5, 2025
@possumbilities
Copy link
Contributor

@Queen-codes what's your approach here. The overall design of the search-index context for the main site is something that serves the main site better in its current design, but I agree trying to provide some parity would be useful.

My worry is we don't want to make them 1:1 since one is an internal search page on a larger website, and the other is a main search hub landing page itself.

@Queen-codes
Copy link
Contributor Author

Hi @possumbilities , thanks for explaining this! Initially, my approach was to make it look exactly like the search-index page, but now I see why that might not be the best idea. I'm thinking of focusing on aligning the input field instead. What do you think?

@possumbilities
Copy link
Contributor

@Queen-codes I think there's definitely room for trying to make them visually similar and related, and look forward to your approach!

@Queen-codes Queen-codes linked a pull request Feb 7, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants