From 7fcd0c33aed4de723ecf0a80a4e1a3c8dee83a45 Mon Sep 17 00:00:00 2001 From: Steven Borrelli Date: Tue, 8 Oct 2024 14:28:08 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Philippe Scorsolini --- README.md | 2 ++ example/context/README.md | 4 ---- example/context/composition.yaml | 4 ++-- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 508d10c..8a4fba4 100644 --- a/README.md +++ b/README.md @@ -193,6 +193,8 @@ apiVersion: meta.gotemplating.fn.crossplane.io/v1alpha1 kind: Context data: "apiextensions.crossplane.io/environment": + kind: Environment + apiVersion: internal.crossplane.io/v1alpha1 update: environment nestedEnvUpdate: hello: world diff --git a/example/context/README.md b/example/context/README.md index f6bcff7..21587cd 100644 --- a/example/context/README.md +++ b/example/context/README.md @@ -47,17 +47,13 @@ fields: hello: world update: environment newkey: - apiVersion: internal.crossplane.io/v1alpha1 hello: world - kind: Environment other-context-key: - apiVersion: internal.crossplane.io/v1alpha1 complex: a: b c: d: e f: "1" - kind: Environment kind: Context ``` diff --git a/example/context/composition.yaml b/example/context/composition.yaml index 4b53355..38e75fd 100644 --- a/example/context/composition.yaml +++ b/example/context/composition.yaml @@ -34,8 +34,8 @@ spec: data: # update existing EnvironmentConfig by using the "apiextensions.crossplane.io/environment" key "apiextensions.crossplane.io/environment": - kind: Environment, - apiVersion: internal.crossplane.io/v1alpha1, + kind: Environment + apiVersion: internal.crossplane.io/v1alpha1 update: environment nestedEnvUpdate: hello: world