Fix order of calls in HttpBase step

Fixes an issue when using
`Http::get()->useBrowser()->postBrowserNavigateHook()`. Previously in
this case, when the loader is configured to use the HTTP client, the
post browser navigate hook was actually not set because of an issue
with the order, things happened internally.

Author: otsch

CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [3.4.2] - 2025-03-08
+### Fixed
+* Issue when using `Http::get()->useBrowser()->postBrowserNavigateHook()`. Previously in this case, when the loader is configured to use the HTTP client, the post browser navigate hook was actually not set because of an issue with the order, things happened internally.
+
 ## [3.4.1] - 2025-03-08
 ### Fixed
 * Since, when using the Chrome browser for loading, we can only execute GET requests:

src/Steps/Loading/HttpBase.php

@@ -243,6 +243,7 @@ protected function getRequestFromInputUri(UriInterface $uri): RequestInterface
 
     /**
      * @throws LoadingException
+     * @throws Exception
      */
     protected function getResponseFromRequest(RequestInterface $request): ?RespondedRequest
     {
@@ -273,10 +274,6 @@ private function applyTempLoaderCustomizations(): array
 
         $resetConfig = ['resetToHttpClient' => false, 'resetToBrowser' => false];
 
-        if (!empty($this->postBrowserNavigateHooks) && $loader->usesHeadlessBrowser()) {
-            $loader->browser()->setTempPostNavigateHooks($this->postBrowserNavigateHooks);
-        }
-
         if ($this->skipCache) {
             $loader->skipCacheForNextRequest();
         }
@@ -298,6 +295,10 @@ private function applyTempLoaderCustomizations(): array
             $loader->useHeadlessBrowser();
         }
 
+        if (!empty($this->postBrowserNavigateHooks) && $loader->usesHeadlessBrowser()) {
+            $loader->browser()->setTempPostNavigateHooks($this->postBrowserNavigateHooks);
+        }
+
         return $resetConfig;
     }
 

tests/Steps/Loading/HttpTest.php

@@ -2,8 +2,10 @@
 
 namespace tests\Steps\Loading;
 
+use Closure;
 use Crwlr\Crawler\Input;
 use Crwlr\Crawler\Loader\Http\Exceptions\LoadingException;
+use Crwlr\Crawler\Loader\Http\HeadlessBrowserLoaderHelper;
 use Crwlr\Crawler\Loader\Http\HttpLoader;
 use Crwlr\Crawler\Loader\Http\Messages\RespondedRequest;
 use Crwlr\Crawler\Steps\Loading\Http;
@@ -723,3 +725,33 @@ function () {
         helper_invokeStepWithInput($step);
     },
 );
+
+it(
+    'sets post browser navigate hooks, when useBrowser() was called and the loader is configured to use the HTTP ' .
+    'client',
+    function () {
+        $loader = Mockery::mock(HttpLoader::class)->makePartial();
+
+        $browserHelperMock = Mockery::mock(HeadlessBrowserLoaderHelper::class);
+
+        $loader->shouldReceive('browser')->andReturn($browserHelperMock);
+
+        $browserHelperMock
+            ->shouldReceive('setTempPostNavigateHooks')
+            ->once()
+            ->withArgs(function (array $hooks) {
+                return $hooks[0] instanceof Closure;
+            });
+
+        $respondedRequest = new RespondedRequest(
+            new Request('GET', 'https://www.example.com/woop'),
+            new Response(200, body: Utils::streamFor('Woop')),
+        );
+
+        $loader->shouldReceive('load')->once()->andReturn($respondedRequest);
+
+        $step = Http::get()->setLoader($loader)->useBrowser()->postBrowserNavigateHook(BrowserAction::wait(1.0));
+
+        helper_invokeStepWithInput($step);
+    },
+);