Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No unlock while rotating the screen #273

Open
jivarson opened this issue Feb 22, 2021 · 5 comments
Open

No unlock while rotating the screen #273

jivarson opened this issue Feb 22, 2021 · 5 comments
Labels
type:bug Something isn't working
Milestone

Comments

@jivarson
Copy link

jivarson commented Feb 22, 2021

Description

When rotation is enabled, when trying to unlock a vault while the enter password or biometric auth dialog is present, rotate the screen, after a successful authentication, one is returned to the vault list with the vault still being locked

System Setup

Android 10, oneplus 7
Cryptomator 1.5.12 (though issue has been around for while)

Steps to Reproduce

  1. Enable autorotation
  2. Open Cryptomator in landscape mode
  3. Open a vault with biometric unlocking enabled.
  4. Select vault
  5. When biometric auth dialog is visible, rotate screen
  6. Enter credentials

Expected Behavior

User is presented with the unlocked vaults content

Actual Behavior

User is returned to Cryptomators main window, the vault in question is still locked

Reproducibility

Always

Additional Information

Issue is likely in the way Cryptomator for Android handles change of orientation while prompts or modals are open, they're not retained when the main window is realigned\redrawned

@SailReal SailReal transferred this issue from cryptomator/cryptomator Feb 22, 2021
@SailReal
Copy link
Member

I've no idea why my emulator is currently bottom up in landscape mode but I'm unable to reproduce your problem.

Peek 2021-02-22 20-58

@SailReal SailReal added state:awaiting-response We need further input from the issue author type:bug Something isn't working labels Feb 22, 2021
@jivarson
Copy link
Author

jivarson commented Feb 23, 2021

Your biometric prompt doesn't force portraitmode whereas mine does. Guess my OnePlus-device has a proprietery implementation or something.

I'm no dev, but it seems like when cryptomator enters the rotate\redraw event, it cancels out whatever prompts is going on so it cancels out.

Try to open just the passwordprompt for unlocking a vault in your emulator and rotate the device manually without entering anything in the prompt. For me the prompt dissappears then as well.

@no-response no-response bot removed the state:awaiting-response We need further input from the issue author label Feb 23, 2021
@SailReal SailReal changed the title No biometric unlock when app is in landscape No unlock while rotating the screen Feb 23, 2021
@SailReal
Copy link
Member

Yes, that makes sense, thank you for reporting!
I have generalized your issue somewhat to fit a larger bug cluster.

@storm1ng
Copy link
Contributor

storm1ng commented Apr 1, 2021

I can confirm the issue on my OnePlus 8 Pro and as @jivarson already mentioned it seems to be related to the screen being rotated back to portrait mode after clicking the vault.

@stale

This comment has been minimized.

@stale stale bot added the state:stale Issues without any activity that will be closed automatically label Jun 26, 2021
@SailReal SailReal added this to the Backlog milestone Jun 28, 2021
@stale stale bot removed the state:stale Issues without any activity that will be closed automatically label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants