Cancel regular unmount if filesystem is still in use #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding isNotSafeToUnmount() method to FuseNioAdapter interface * AbstractMount directly implements unmount() and unmountForced() * AbstractMount has two additional _abstract_ methods for internal unmounting * ReadOnlyAdapter implements isNotSafeToUnmount * aborting unmount() if is not safe and throw CommandFailedException
overheadhunter
requested changes
Sep 24, 2020
src/main/java/org/cryptomator/frontend/fuse/FuseNioAdapter.java
Outdated
Show resolved
Hide resolved
| if (threadnum % 2 == 0) { | ||
| try (PathLock lockThread = lockManager.createPathLock("/foo/bar/baz").tryForWriting()) { | ||
| counter.incrementAndGet(); | ||
| Thread.sleep(10); |
There was a problem hiding this comment.
why sleep?
why 4 threads? one for read, one for write should be sufficient..?
| try (PathLock lockThread = lockManager.createPathLock("/foo/bar/baz").tryForWriting()) { | ||
| counter.incrementAndGet(); | ||
| Thread.sleep(10); | ||
| maxCounter.set(Math.max(counter.get(), maxCounter.get())); |
There was a problem hiding this comment.
what is the purpose of maxCounter (btw this is not an atomic operation)
* add unit test if only read lock is accquired * further simplification of the unit test structure
overheadhunter
approved these changes
Sep 25, 2020
|
Coverage decreased per file
===========================
- src/main/java/org/cryptomator/frontend/fuse/locks/PathWLockImpl.java -15
- src/main/java/org/cryptomator/frontend/fuse/OpenFileFactory.java -2
- src/main/java/org/cryptomator/frontend/fuse/locks/PathLockBuilderImpl.java -8
Complexity increasing per file
==============================
- src/main/java/org/cryptomator/frontend/fuse/locks/PathWLockImpl.java 2
- src/main/java/org/cryptomator/frontend/fuse/locks/PathRLockImpl.java 2
- src/main/java/org/cryptomator/frontend/fuse/locks/AlreadyLockedException.java 1
See the complete overview on Codacy |
infeo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #47.
It adds the method
isNotSafeToUnmount()toFuseNioAdapter, to indicate wether the filesystem is in a state where the (internal) regular unmount method should be called.To achieve this, the number of open files is checked and wether there is a pending (path locking) file system operation.