Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing error message if OneDrive (or other cloud service) session expired #242

Closed
2 tasks done
overheadhunter opened this issue Jul 14, 2022 · 4 comments
Closed
2 tasks done
Labels
type:bug Something isn't working
Milestone

Comments

@overheadhunter
Copy link
Member

Please agree to the following

Summary

When trying to unlock a vault with FaceID, I got an error message saying "unlock cancelled" when the app was really unable to renew the session with the cloud storage provider.

System Setup

  • iOS: 15.5 (19F77)
  • Cryptomator: 2.3.0 (967)

Cloud Type

OneDrive

Steps to Reproduce

  1. Add a vault on OneDrive (other services may behave the same and have even shorter living sessions?)
  2. Don't access the vault for several weeks (according to my logs, > 4-6 weeks?)
  3. Try to access the vault after the session timed out

Expected Behavior

  1. Ideally, Cryptomator can refresh the session itself
  2. Alternatively, it should show a meaningful error AND allow to manually re-login to existing accounts (as you probably don't want to logout and remove corresponding vaults)

Actual Behavior

Unlock fails with generic error message (can't recall the exact text).

Furthermore, there is no obvious way to renew the session. Even in the main app under cloud services, the account doesn't show up as expired.

Reproducibility

Intermittent

Relevant Log Output

# file provider:
2022/07/14 19:25:01:873  enumerateItems getAdapter failed with: biometricalUnlockCanceled(biometryName: "Face ID") for identifier: NSFileProviderItemIdentifier(_rawValue: NSFileProviderRootContainerItemIdentifier)

# main app:
2022/07/14 19:26:10:787  Error: unauthorized

Anything else?

Workaround: No need to log out and in again on OneDrive. Instead, just add the same account a second time. The app is able to merge this. This way, you can keep the vaults.

@overheadhunter overheadhunter added the type:bug Something isn't working label Jul 14, 2022
@tobihagemann
Copy link
Member

tobihagemann commented Jul 14, 2022

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Issues without any activity that will be closed automatically label Jul 15, 2023
@tobihagemann tobihagemann removed the state:stale Issues without any activity that will be closed automatically label Jul 15, 2023
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Issues without any activity that will be closed automatically label Jul 15, 2024
@tobihagemann tobihagemann removed the state:stale Issues without any activity that will be closed automatically label Jul 15, 2024
@tobihagemann tobihagemann added this to the 2.6.3 milestone Oct 30, 2024
@tobihagemann
Copy link
Member

Confusing error message fixed in 2.6.3. However, we're still not quite done yet, see #387. Even though this issue is not fully fixed, I'll close this in favor of #387.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants