Skip to content

Bzip2: Possible oversight? #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jspark311 opened this issue Dec 7, 2015 · 3 comments
Open

Bzip2: Possible oversight? #8

jspark311 opened this issue Dec 7, 2015 · 3 comments

Comments

@jspark311
Copy link

Hi there,

I'm not sure if it was an oversight or not, but the documentation is misleading. I cannot use Bzip2 to compress anything but a stream. I forked your repo and did the needful. Should I submit a PR, or was the omission intentional?

@cscott
Copy link
Owner

cscott commented Feb 22, 2018

PRs are always helpful, if nothing else than to clarify what you're talking about.

@dkg
Copy link

dkg commented Apr 25, 2018

take a look at #20 please, i think it might address this concern. @jspark311, can you verify?

@jspark311
Copy link
Author

jspark311 commented Apr 29, 2018

No. My issue was an API asymmetry.
https://github.com/cscott/compressjs/blob/master/lib/Bzip2.js#L879

I made local changes to the package, but never submitted them. Since cryptjs was not operable at the time, browser-based compression was not on my priority list.

I followed the thread "compressjs dependency #695", but my issue wasn't related to what those guys are talking about, and your change doesn't address the gap this issue is related to.

I needed "compressBlock" as well as "decompressBlock".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants