use os.makedirs/shutil.copy2 instead of cp from scripting

Author: mcflugen

bmi_tester/tests/conftest.py

@@ -3,9 +3,9 @@
 import os
 import shutil
 from collections.abc import Generator
-from packaging.version import Version
 
 import pytest
+from packaging.version import Version
 
 
 @contextlib.contextmanager
@@ -61,7 +61,7 @@ def load_component(entry_point):
     Bmi = None
 else:
     Bmi = load_component(class_to_test)
-INPUT_FILE = os.environ.get("BMITEST_INPUT_FILE", None)
+INPUT_FILE = os.environ.get("BMITEST_INPUT_FILE")
 # BMI_VERSION_STRING = os.environ.get("BMI_VERSION_STRING", "1.1")
 BMI_VERSION_STRING = os.environ.get("BMI_VERSION_STRING", "2.0")
 BMI_VERSION = Version(BMI_VERSION_STRING)
@@ -87,9 +87,9 @@ def get_test_parameters(infile=None, count=0):
     infile = infile or INPUT_FILE
 
     try:
-        with open(".ROOT_DIR", "r") as fp:
+        with open(".ROOT_DIR") as fp:
             root_dir = fp.read()
-    except IOError:
+    except OSError:
         root_dir = "."
     if count > 1:
         raise RuntimeError()
@@ -127,7 +127,7 @@ def bmi():
 
 @pytest.fixture(scope="session")
 def initialized_bmi(tmpdir_factory, infile=None, manifest=None):
-    infile = os.environ.get("BMITEST_INPUT_FILE", None)
+    infile = os.environ.get("BMITEST_INPUT_FILE")
     manifest = os.environ.get("BMITEST_MANIFEST", infile or "").splitlines()
 
     tmp = tmpdir_factory.mktemp("data")
@@ -145,12 +145,13 @@ def initialized_bmi(tmpdir_factory, infile=None, manifest=None):
 
 @pytest.fixture(scope="function")
 def staged_tmpdir(tmpdir, infile=None, manifest=None):
-    infile = os.environ.get("BMITEST_INPUT_FILE", None)
+    infile = os.environ.get("BMITEST_INPUT_FILE")
     manifest = os.environ.get("BMITEST_MANIFEST", infile or "").splitlines()
     with tmpdir.as_cwd() as prev:
         for file_ in [fname.strip() for fname in manifest]:
             if file_:
-                cp(os.path.join(str(prev), file_), tmpdir / file_, create_dirs=True)
+                os.makedirs(tmpdir / os.path.dirname(file_), exist_ok=True)
+                shutil.copy2(prev / file_, tmpdir / file_)
     return tmpdir