Skip to content

Commit 813328c

Browse files
committed
modifications for new gimli, standard-names
1 parent 4448d91 commit 813328c

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

src/bmi_tester/_tests/stage_1/info_test.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import warnings
22

33
import pytest
4-
import standard_names
4+
from standard_names.standardname import StandardName
5+
from standard_names.standardname import is_valid_name
56

67

78
def test_get_component_name(initialized_bmi):
@@ -15,8 +16,8 @@ def test_get_component_name(initialized_bmi):
1516
def test_var_names(var_name):
1617
"""Test var names are valid."""
1718
assert isinstance(var_name, str)
18-
if standard_names.is_valid_name(var_name):
19-
standard_names.StandardName(var_name)
19+
if is_valid_name(var_name):
20+
StandardName(var_name)
2021
else:
2122
warnings.warn(f"not a valid standard name: {var_name}", stacklevel=2)
2223

src/bmi_tester/api.py

+10-7
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,16 @@
44
from collections.abc import Sequence
55

66
try:
7-
import gimli
7+
from gimli._udunits2 import UdunitsError
8+
from gimli.errors import IncompatibleUnitsError
9+
from gimli.errors import UnitNameError
10+
from gimli.units import units
811
except ImportError:
912
WITH_GIMLI_UNITS = False
1013
SECONDS = None
1114
else:
1215
WITH_GIMLI_UNITS = True
13-
SECONDS = gimli.units.Unit("s")
16+
SECONDS = units.Unit("s")
1417

1518
import pytest
1619

@@ -57,21 +60,21 @@ def check_bmi(
5760

5861
def check_unit_is_valid(unit):
5962
try:
60-
gimli.units.Unit(unit)
61-
except gimli.UnitNameError:
63+
units.Unit(unit)
64+
except (UnitNameError, UdunitsError):
6265
return False
6366
else:
6467
return True
6568

6669

6770
def check_unit_is_time(unit):
6871
try:
69-
gimli.units.Unit(unit).to(SECONDS)
70-
except gimli.IncompatibleUnitsError:
72+
units.Unit(unit).to(SECONDS)
73+
except (IncompatibleUnitsError, UdunitsError):
7174
return False
7275
else:
7376
return True
7477

7578

7679
def check_unit_is_dimensionless(unit):
77-
return gimli.units.Unit(unit).is_dimensionless
80+
return units.Unit(unit).is_dimensionless

0 commit comments

Comments
 (0)