From f68f36b90e6bbec933f2aac797ab281832bdf89f Mon Sep 17 00:00:00 2001 From: skyeslattery Date: Tue, 9 Sep 2025 12:43:16 -0400 Subject: [PATCH] fix n+1 in ItemSerializer --- src/item/serializers.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/item/serializers.py b/src/item/serializers.py index ec83d4c..c47ebd3 100644 --- a/src/item/serializers.py +++ b/src/item/serializers.py @@ -10,11 +10,11 @@ class ItemSerializer(serializers.ModelSerializer): def get_dietary_preferences(self, obj): """Get list of dietary preference names""" - return list(obj.dietary_preferences.values_list('name', flat=True)) + return [pref.name for pref in obj.dietary_preferences.all()] def get_allergens(self, obj): """Get list of allergen names""" - return list(obj.allergens.values_list('name', flat=True)) + return [allergen.name for allergen in obj.allergens.all()] def create(self, validated_data): dietary_prefs = validated_data.pop('dietary_preferences', [])