Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ubiquitous tree.id! null escape hatch #1

Open
sampsyo opened this issue Oct 9, 2016 · 0 comments
Open

Avoid ubiquitous tree.id! null escape hatch #1

sampsyo opened this issue Oct 9, 2016 · 0 comments

Comments

@sampsyo
Copy link
Collaborator

sampsyo commented Oct 9, 2016

I've ported the source to use strictNullChecks, but a bunch of ! operators appear on the id field of syntax nodes. (The TS calls these "null assertions," but that's misleading—they are unchecked, so they're not very assert-y.) We should replace these with a safe way of enforcing that the id field exists on stamped ASTs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant