Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the PR template #7

Closed
aslakhellesoy opened this issue May 16, 2022 · 3 comments
Closed

Simplify the PR template #7

aslakhellesoy opened this issue May 16, 2022 · 3 comments

Comments

@aslakhellesoy
Copy link
Contributor

People don’t fill it in properly anyway and the number of emoji hurts my eyes.

E9030529-B38A-4ED1-891A-9FAAE3AA6328

@mpkorstanje
Copy link
Contributor

People don’t fill it in properly anyway

But when they do it's useful.

@aurelien-reeves
Copy link
Contributor

I totally agree with Aslak:

  • emojis are too much here (and yet I am a huge user of emojis)
  • there is too much text: it needs to be simplified (we could still keep the same sections)
  • there is a feature in github which shows progress bar regarding the checkboxes in a PR description. But the actual template do not take benefit of this: all the checkboxes in the template do not act as a todo-list

@mattwynne
Copy link
Member

Disagree. Most people do fill it in, and the information they provide is useful.

This PR text is the result of several iterations I've made, based on watching real contributors trying to make their first pull requests. The emojis add some warmth and make the process less daunting for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants