-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perl] Generated Languages.pm as part of the build process #176
Conversation
18b5c00
to
9fd1084
Compare
c2aa3d4
to
63a22b5
Compare
The latest Iteration of this PR generates Languages.pm before testing and release artefact building. It does that by extending the f we want to run the tests based on what is in the release tarball, we need to install its content. Looking at how Ruby does it, I see it uses Concluding: I think this PR brings the Perl situation in line with what Ruby does. |
730a3e1
to
2347a3e
Compare
Please let me know what I can do to expedite this PR, or let me know what other direction to take. The PR is created in response to the feedback on the Perl approach with a pre-built Languages.pm file in the repository (which is neither what other languages do, nor desirable, as per the feedback). If a different approach is required, I'll work on that. |
Cheers! I've got next week Thursday planned for core work. So, pending availability, hopefully by then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Eric thanks for keeping up with this! It has taken some time. 😅
I've cleaned up the Makefile
and pushed some changes so we can run the acceptance tests against the artifact produced by dzil build
.
One item I'm not sure how to fix yet is running the "unit test" before the acceptance tests. I think it should work with dzil test
but I'm not sure how to get that working in a GitHub action.
Could you help with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, got something that isn't horrible to work.
Let me know if you see I've committed any sins against Perl. 😉
@mpkorstanje looking very nice! Thanks for ironing out the Makefile stuff and shaping a bit more to your linking. No sins againt Perl paradigms that I can see. I'd say: if it doesn't add new failures, this is an improvement. Let's merge it! |
Thanks for merging! Another action item off my list. |
Fixes #32
🤔 What's changed?
The Languages.pm file is now generated upon building the release artifacts or when running the test suite.
⚡️ What's your motivation?
Fixes: #32 (Languages.pm not mergeable)
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Does this address the concern sufficiently?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.