Skip to content

Commit 7355b51

Browse files
author
The Senate
committed
v1.0.2
1 parent d4f2600 commit 7355b51

12 files changed

+33
-22
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## [1.0.2] - 2020-12-07
8+
### Fixed
9+
- Removed benchmark's dependency on angle files entirely.
10+
711
## [1.0.1] - 2020-12-06
812
### Changed
913
- Logs and benchmarks now have timestamps prefixed to the filename.

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ The directory where the app searches for angle lists. Lists are expected to have
109109
#### Logs
110110

111111
If enabled in the settings, log files will be saved in this folder.
112-
The log filename will be `<timestamp> log.txt`. Will be overwritten on each execution.
112+
The log filename will be `<timestamp> log.txt`.
113113

114114
#### Output
115115

XRD-TAF/Assets/Scripts/DataHandler.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ public void Compute(Preset preset, Logger logger, PerformanceReport report, bool
349349
_shaderAdapter = _builder
350350
.SetLogger(logger)
351351
.SetWriteFactors(write)
352-
.SetPerformanceReport(report) // TODO: see if report is generated correctly, otherwise use report as return.
352+
.SetPerformanceReport(report)
353353
.SetProperties(preset)
354354
.SetAngles(angles)
355355
.AutoSetShader()

XRD-TAF/Assets/Scripts/adapter/IntegratedModeAdapter.cs

+3-2
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,9 @@ public IntegratedModeAdapter(
4949
Preset preset,
5050
bool writeFactors,
5151
Logger customLogger,
52-
double[] angles
53-
) : base(shader, preset, writeFactors, customLogger, angles)
52+
double[] angles,
53+
PerformanceReport performanceReport
54+
) : base(shader, preset, writeFactors, customLogger, angles, performanceReport)
5455
{
5556
if (logger == null) SetLogger(customLogger);
5657
logger.Log(Logger.EventType.Class, $"{CLASS_NAME} created.");

XRD-TAF/Assets/Scripts/adapter/PlaneModeAdapter.cs

+4-2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
using System.IO;
33
using System.Linq;
44
using model;
5+
using tests;
56
using UnityEngine;
67
using util;
78
using static tests.PerformanceReport.TimeInterval;
@@ -42,8 +43,9 @@ public PlaneModeAdapter(
4243
ComputeShader shader,
4344
Preset preset,
4445
bool writeFactors,
45-
Logger customLogger
46-
) : base(shader, preset, writeFactors, customLogger)
46+
Logger customLogger,
47+
PerformanceReport performanceReport
48+
) : base(shader, preset, writeFactors, customLogger, null, performanceReport)
4749
{
4850
if (logger == null) SetLogger(customLogger);
4951
logger.Log(Logger.EventType.Class, $"{nameof(PlaneModeAdapter)} created.");

XRD-TAF/Assets/Scripts/adapter/PointModeAdapter.cs

+3-2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
using System.IO;
55
using System.Linq;
66
using model;
7+
using tests;
78
using UnityEngine;
89
using util;
910
using static tests.PerformanceReport.TimeInterval;
@@ -39,8 +40,8 @@ private static string Context(string methodName, string className = CLASS_NAME)
3940
#region Constructors
4041

4142
public PointModeAdapter(ComputeShader shader, Preset preset, bool writeFactors, Logger customLogger,
42-
double[] angles)
43-
: base(shader, preset, writeFactors, customLogger, angles)
43+
double[] angles, PerformanceReport performanceReport)
44+
: base(shader, preset, writeFactors, customLogger, angles, performanceReport)
4445
{
4546
if (logger == null) SetLogger(customLogger);
4647
logger.Log(Logger.EventType.Class, $"{nameof(PointModeAdapter)} created.");

XRD-TAF/Assets/Scripts/adapter/ShaderAdapter.cs

+5-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public abstract class ShaderAdapter
1414
#region Fields
1515

1616
protected Logger logger;
17-
protected PerformanceReport stopwatch;
17+
internal PerformanceReport stopwatch;
1818
protected readonly bool writeFactors;
1919

2020
private protected readonly ComputeShader shader;
@@ -49,19 +49,21 @@ protected ShaderAdapter(
4949
Preset preset,
5050
bool writeFactors,
5151
Logger logger = null,
52-
double[] angles = null
52+
double[] angles = null,
53+
PerformanceReport performanceReport = null
5354
)
5455
{
5556
this.shader = shader;
5657
properties = preset.properties;
5758
metadata = preset.metadata;
5859
this.writeFactors = writeFactors;
5960
if (logger != null) SetLogger(logger);
60-
if (stopwatch == null)
61+
if (performanceReport == null)
6162
{
6263
var info = PerformanceReport.InputInfo.FromPreset(preset);
6364
stopwatch = new PerformanceReport(info);
6465
}
66+
else stopwatch = performanceReport;
6567
if (angles != null) this.angles = angles;
6668

6769
stopwatch.Start(PerformanceReport.TimeInterval.Category.Total);

XRD-TAF/Assets/Scripts/adapter/ShaderAdapterBuilder.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public class ShaderAdapterBuilder
2020
private Preset _preset;
2121
private static Dictionary<AbsorptionProperties.Mode, ComputeShader> _shaderMapping;
2222
private Logger _logger;
23-
private PerformanceReport _report; // TODO: use in ShaderAdapter.
23+
private PerformanceReport _report;
2424
private double[] _angles;
2525

2626
#endregion
@@ -41,13 +41,13 @@ public ShaderAdapter Build()
4141
switch (_preset.properties.absorption.mode)
4242
{
4343
case AbsorptionProperties.Mode.Point:
44-
adapter = new PointModeAdapter(_shader, _preset, _writeFactors, _logger, _angles);
44+
adapter = new PointModeAdapter(_shader, _preset, _writeFactors, _logger, _angles, _report);
4545
break;
4646
case AbsorptionProperties.Mode.Area:
47-
adapter = new PlaneModeAdapter(_shader, _preset, _writeFactors, _logger);
47+
adapter = new PlaneModeAdapter(_shader, _preset, _writeFactors, _logger, _report);
4848
break;
4949
case AbsorptionProperties.Mode.Integrated:
50-
adapter = new IntegratedModeAdapter(_shader, _preset, _writeFactors, _logger, _angles);
50+
adapter = new IntegratedModeAdapter(_shader, _preset, _writeFactors, _logger, _angles, _report);
5151
break;
5252
}
5353

XRD-TAF/Assets/Scripts/tests/PerformanceReport.cs

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ public class PerformanceReport
1616
private InputInfo _inputInfo;
1717
private LinkedList<TimeInterval> _total, _shader, _buffer, _io;
1818
private Stack<TimeInterval> _intervals;
19-
// TODO: use stack or deque for nested intervals.
2019

2120
public readonly List<string> headRow = new List<string> {
2221
"time-total", "time-shader", "time-buffer", "time-io", // time

XRD-TAF/Assets/Scripts/ui/MainPanel.cs

+4-3
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,11 @@ public class MainPanel : MonoBehaviour {
4848
public InputField fieldRayOffsetY;
4949
public Dropdown dropdownRayProfile;
5050

51-
public Preset selectedPreset; // use if a saved preset was selected (incl. default).
5251
internal Preset preset; // use for current state of properties.
52+
53+
// TODO: implement
54+
public Preset selectedPreset; // use if a saved preset was selected (incl. default).
5355
private bool presetHasChanged;
54-
// TODO: remember to deep-copy the preset!
5556

5657
// for component-wise / group-wise selection of case-specific input fields.
5758
public GameObject inputGroupDetector;
@@ -135,7 +136,7 @@ void SetComponent(string text, ref Vector2 variable, int position)
135136

136137
public void FillFromPreset(Preset source)
137138
{
138-
FillFromPreset(source.metadata); // not necessary for
139+
FillFromPreset(source.metadata);
139140
FillFromPreset(source.properties.absorption);
140141
FillFromPreset(source.properties.angle);
141142
FillFromPreset(source.properties.detector);

XRD-TAF/Presets/benchmark.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"angleCount": 30,
1414
"angleEnd": 90,
1515
"angleStart": 0,
16-
"pathToAngleFile": "(0,180,1.0)"
16+
"pathToAngleFile": null
1717
},
1818
"detector": {
1919
"distToSample": 240.18,

XRD-TAF/ProjectSettings/ProjectSettings.asset

+3-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ PlayerSettings:
1313
useOnDemandResources: 0
1414
accelerometerFrequency: 60
1515
companyName: DefaultCompany
16-
productName: UnityStuff
16+
productName: XRD-TAF
1717
defaultCursor: {fileID: 0}
1818
cursorHotspot: {x: 0, y: 0}
1919
m_SplashScreenBackgroundColor: {r: 0.13725491, g: 0.12156863, b: 0.1254902, a: 1}
@@ -126,7 +126,7 @@ PlayerSettings:
126126
16:10: 1
127127
16:9: 1
128128
Others: 1
129-
bundleVersion: 0.1
129+
bundleVersion: 1.0.2
130130
preloadedAssets: []
131131
metroInputSource: 0
132132
wsaTransparentSwapchain: 0
@@ -588,6 +588,7 @@ PlayerSettings:
588588
il2cppCompilerConfiguration: {}
589589
managedStrippingLevel: {}
590590
incrementalIl2cppBuild: {}
591+
suppressCommonWarnings: 1
591592
allowUnsafeCode: 0
592593
useDeterministicCompilation: 1
593594
additionalIl2CppArgs:

0 commit comments

Comments
 (0)