Fix warnings

Author: sebastienros

src/FastExpressionCompiler/ILReader.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #if DEBUG
 // #define DEBUG_INTERNALS
 #endif
@@ -7,6 +9,7 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Diagnostics;
+using System.Globalization;
 using System.Reflection;
 using System.Reflection.Emit;
 using System.Text;
@@ -22,7 +25,13 @@ namespace FastExpressionCompiler.LightExpression.ILDecoder;
 namespace FastExpressionCompiler.ILDecoder;
 #endif
 
+#pragma warning disable IDE0079 // Remove unnecessary suppression (like the ones below when they don't apply)
+#pragma warning disable IDE1006 // Naming rule violation: Identifiers should be cased correctly
+#pragma warning disable IDE0038 // Use pattern matching
+#pragma warning disable IDE0057 // Use range operator
+
 #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
+#pragma warning disable CA1305 // Specify IFormatProvider
 
 [UnconditionalSuppressMessage("Trimming", "IL2026:Members annotated with 'RequiresUnreferencedCodeAttribute' require dynamic access otherwise can break functionality when trimming application code", Justification = "Uses reflection on internal types and is not trim-compatible.")]
 public static class ILReaderFactory
@@ -109,7 +118,11 @@ public static StringBuilder ToILString(this IEnumerable<ILInstruction> ilInstruc
                     case OperandType.InlineMethod:
                         var m = (InlineMethodInstruction)il;
                         var sig = m.Method.ToString();
+#if NET
+                        var paramStart = sig.IndexOf('(', StringComparison.Ordinal);
+#else
                         var paramStart = sig.IndexOf('(');
+#endif
                         var paramList = paramStart == -1 ? "()" : sig.Substring(paramStart);
 
                         if (m.Method is MethodInfo met)
@@ -556,8 +569,12 @@ public class MethodBaseILProvider : IILProvider
 
     public MethodBaseILProvider(MethodBase method)
     {
+#if NET
+        ArgumentNullException.ThrowIfNull(method);
+#else
         if (method == null)
             throw new ArgumentNullException(nameof(method));
+#endif
 
         var methodType = method.GetType();
         if (methodType != _runtimeMethodInfoType & methodType != _runtimeConstructorInfoType)
@@ -613,21 +630,21 @@ public DynamicMethodILProvider(DynamicMethod method)
 
 public static class ILFormatter
 {
-    public static StringBuilder Int32ToHex(StringBuilder sb, int int32) => sb.Append(int32.ToString("X8"));
-    public static StringBuilder Int16ToHex(StringBuilder sb, int int16) => sb.Append(int16.ToString("X4"));
-    public static StringBuilder Int8ToHex(StringBuilder sb, int int8) => sb.Append(int8.ToString("X2"));
-    public static StringBuilder Argument(StringBuilder sb, int ordinal) => sb.Append($"V_{ordinal}");
-    public static StringBuilder Label(StringBuilder sb, int offset) => sb.Append($"IL_{offset:D4}");
+    public static StringBuilder Int32ToHex(StringBuilder sb, int int32) => sb.Append(int32.ToString("X8", CultureInfo.InvariantCulture));
+    public static StringBuilder Int16ToHex(StringBuilder sb, int int16) => sb.Append(int16.ToString("X4", CultureInfo.InvariantCulture));
+    public static StringBuilder Int8ToHex(StringBuilder sb, int int8) => sb.Append(int8.ToString("X2", CultureInfo.InvariantCulture));
+    public static StringBuilder Argument(StringBuilder sb, int ordinal) => sb.AppendFormat(CultureInfo.InvariantCulture, "V_{0}", ordinal);
+    public static StringBuilder Label(StringBuilder sb, int offset) => sb.AppendFormat(CultureInfo.InvariantCulture, "IL_{0:D4}", offset);
 
     public static StringBuilder MultipleLabels(StringBuilder sb, int[] offsets)
     {
         var length = offsets.Length;
         for (var i = 0; i < length; i++)
         {
-            sb.AppendFormat(i == 0 ? "(" : ", ");
+            sb.Append(i == 0 ? "(" : ", ");
             sb.Append(Label(sb, offsets[i]));
         }
-        sb.AppendFormat(")");
+        sb.Append(')');
         return sb;
     }
 
@@ -648,9 +665,9 @@ public static StringBuilder EscapedString(StringBuilder sb, string str)
             else if (ch == '\"')
                 sb.Append("\\\"");
             else if (ch == '\\')
-                sb.Append("\\");
+                sb.Append('\\');
             else if (ch < 0x20 || ch >= 0x7f)
-                sb.AppendFormat("\\u{0:x4}", (int)ch);
+                sb.AppendFormat(CultureInfo.InvariantCulture, "\\u{0:x4}", (int)ch);
             else
                 sb.Append(ch);
         }
@@ -663,10 +680,10 @@ public static StringBuilder SigByteArrayToString(StringBuilder sb, byte[] sig)
         var length = sig.Length;
         for (var i = 0; i < length; i++)
         {
-            sb.AppendFormat(i == 0 ? "SIG [" : " ");
+            sb.Append(i == 0 ? "SIG [" : " ");
             sb.Append(Int8ToHex(sb, sig[i]));
         }
-        sb.AppendFormat("]");
+        sb.Append(']');
         return sb;
     }
 }

src/FastExpressionCompiler/TestTools.cs

@@ -1,4 +1,6 @@
-using System;
+#nullable disable
+
+using System;
 using System.Linq;
 using System.Text;
 using System.Reflection;
@@ -19,18 +21,25 @@ namespace FastExpressionCompiler;
 
 using FastExpressionCompiler.ILDecoder;
 using FastExpressionCompiler.ImTools;
+using System.Globalization;
 using System.Linq.Expressions;
 #endif
 
+#pragma warning disable IDE0079 // Remove unnecessary suppression (like the ones below when they don't apply)
+#pragma warning disable IDE0250, IDE0251 // Readonly modifier
+
 #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
+#pragma warning disable CA1305 // Specify IFormatProvider
 
 [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode", Justification = "This is used for the testing purposes only.")]
 public static class TestTools
 {
-    public static bool AllowPrintIL = false;
-    public static bool AllowPrintCS = false;
-    public static bool AllowPrintExpression = false;
-    public static bool DisableAssertOpCodes = false;
+#pragma warning disable CA2211 // Non-constant fields should not be visible
+    public static bool AllowPrintIL;
+    public static bool AllowPrintCS;
+    public static bool AllowPrintExpression;
+    public static bool DisableAssertOpCodes;
+#pragma warning restore CA2211 // Non-constant fields should not be visible
 
     static TestTools()
     {
@@ -567,7 +576,7 @@ public static bool StartsWith(string expected, string actual,
         string expectedName = "expected",
         [CallerArgumentExpression(nameof(actual))]
         string actualName = "actual") =>
-        actual.StartsWith(expected) ? true : throw new AssertionException(
+        actual.StartsWith(expected, StringComparison.Ordinal) ? true : throw new AssertionException(
             $"Expected string `StartsWith({expectedName}, {actualName})`, but found expected `{expected.ToCode()}` is not at start of `{actual.ToCode()}`");
 }
 
@@ -613,6 +622,7 @@ public record struct TestStats(
     int FailureCount);
 
 [Flags]
+[SuppressMessage("Naming", "CA1711:Identifiers should not have incorrect suffix")]
 public enum TestFlags : byte
 {
     Default = 0,
@@ -628,13 +638,16 @@ class CallerMemberNameAttribute : Attribute { }
 class CallerLineNumberAttribute : Attribute { }
 
 [AttributeUsage(AttributeTargets.Parameter, Inherited = false)]
-class CallerArgumentExpression : Attribute
+class CallerArgumentExpressionAttribute : Attribute
 {
-    public CallerArgumentExpression(string parameterName) { }
+#pragma warning disable IDE0060 // Remove unused parameter
+    public CallerArgumentExpressionAttribute(string parameterName) { }
+#pragma warning restore IDE0060 // Remove unused parameter
 }
 #endif
 
 /// <summary>Wrapper for the context per test method</summary>
+[SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "<Pending>")]
 [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode", Justification = "This is used for the testing purposes only.")]
 public struct TestContext
 {
@@ -993,7 +1006,7 @@ public bool StartsWith(string expected, string actual,
         string expectedName = "<expected>",
         [CallerArgumentExpression(nameof(actual))]
         string actualName = "<actual>") =>
-        actual.StartsWith(expected) ? true : throw new AssertionException(
+        actual.StartsWith(expected, StringComparison.Ordinal) ? true : throw new AssertionException(
             $"Expected string `StartsWith({expectedName}, {actualName})`, but found expected `{expected.ToCode()}` is not at start of `{actual.ToCode()}`");
 }