Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a naive sync configure implementation #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

skeet70
Copy link

@skeet70 skeet70 commented Feb 7, 2025

This is what worked for my use case, but I'm sure ideally some amount of this would be enforced at the type level.

Fixes #12

This is what worked for my use case, but I'm sure ideally some amount of
this would be enforced at the type level.
@dahlia
Copy link
Owner

dahlia commented Feb 8, 2025

Thanks for your contribution! 🙏🏼 I'll look into this soon!

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 93.39623% with 7 lines in your changes missing coverage. Please review.

Project coverage is 96.07%. Comparing base (327c947) to head (bed4169).

Files with missing lines Patch % Lines
logtape/config.ts 93.39% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   96.27%   96.07%   -0.20%     
==========================================
  Files          11       11              
  Lines         992     1096     +104     
  Branches      231      268      +37     
==========================================
+ Hits          955     1053      +98     
- Misses         37       43       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, there seems to be a lot of duplicate code between configure() and configureSync(). Is it possible to extract the duplicate code into common functions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sync configure
2 participants