Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: isCallbackFromSts doesn't respect trailing slash in the url #2040

Open
rammba opened this issue Nov 1, 2024 · 0 comments
Open

[Bug]: isCallbackFromSts doesn't respect trailing slash in the url #2040

rammba opened this issue Nov 1, 2024 · 0 comments

Comments

@rammba
Copy link

rammba commented Nov 1, 2024

Version

18.0.2

Please provide the exception or error you saw

No exceptions nor errors, just failed login flow.

Steps to reproduce the behavior

My app is using Azure B2C authentication provider. In the B2C configuration I have auth redirectUrl without trailing slash, but looks like B2C adds it implicitly.
B2C config

I've updated v18.0.1 to v18.0.2 because I had this line "angular-auth-oidc-client": "^18.0.1", in package.json file. After update, my login flow stopped working without console errors and exceptions. After bunch of hours I figured out that there is a trailing slash in the URL which causing the problem:
Example

I wasn't aware that checkRedirectUrlWhenCheckingIfIsCallback setting was introduced, and less that it's enabled by default. I solved the problem using v18.0.1 explicitly even that I know setting it to false would also work.

This flag is introduced in #1976. @erichjsonfosse @FabianGosebrink can you please take a look if this case can be solved/fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant