[GitLab] Move to gitbeaker/rest

Major version 36 of gitbeaker contains changes to the type system and the structure of the framework.

Moved to gitbeaker/rest which is the expected package to consume going forward, and adjusted our usage of the types to match the changes in the framework.

Additionally gitbeaker now leverages native-fetch  under the hood which nock does not support. Version 4.0.0 of nock in beta can handle testing native-fetch, but does not yet support recording fixtures. To continue using nock for testing without updating to the beta-version, a fetch polyfill has been introduced to use for the gitlab api tests.

Author: heltoft

CHANGELOG.md

@@ -17,6 +17,8 @@
 <!-- Your comment below this -->
 - Upgrade `node` engine from `>=14.13.1` to `>=18` [@heltoft]
 - Upgrade `@types/node` from `^10.11.3` to `18.19.18` [@heltoft]
+- GitLab: [#1386] Move from `@gitbeaker/node` to `@gitbeaker/rest` [@heltoft]
+- GitLab: [#1412] Danger fails to create inline comments on Gitlab [@heltoft]
 <!-- Your comment above this -->
 
 ## 11.3.1

package.json

@@ -150,8 +150,7 @@
     "debug": "^4.1.1",
     "fast-json-patch": "^3.0.0-1",
     "get-stdin": "^6.0.0",
-    "@gitbeaker/core": "^35.8.1",
-    "@gitbeaker/node": "^35.8.1",
+    "@gitbeaker/rest": "^38.0.0",
     "http-proxy-agent": "^5.0.0",
     "https-proxy-agent": "^5.0.1",
     "hyperlinker": "^1.0.0",

scripts/danger-dts.ts

@@ -9,8 +9,7 @@ const createDTS = () => {
 //
 
 import { Octokit as GitHub } from "@octokit/rest"
-import { Gitlab, Types } from "@gitbeaker/node"
-import { Types as CoreTypes } from "@gitbeaker/core/dist"
+import type * as Types from "@gitbeaker/rest"
 import { File } from "parse-diff"
 
 `

source/commands/danger-pr.ts

@@ -13,7 +13,7 @@ import { prepareDangerDSL } from "./utils/runDangerSubprocess"
 import { runRunner } from "./ci/runner"
 import { Platform, getPlatformForEnv } from "../platforms/platform"
 import { CISource } from "../ci_source/ci_source"
-import { getGitLabAPICredentialsFromEnv } from "../platforms/gitlab/GitLabAPI"
+import { getGitLabHostFromEnv } from "../platforms/gitlab/GitLabAPI"
 
 const d = debug("pr")
 const log = console.log
@@ -25,8 +25,6 @@ interface App extends SharedCLI {
   js?: boolean
 }
 
-const gitLabApiCredentials = getGitLabAPICredentialsFromEnv(process.env)
-
 program
   .usage("[options] <pr_url>")
   .description("Emulate running Danger against an existing GitHub Pull Request.")
@@ -43,8 +41,8 @@ program
       !process.env["DANGER_BITBUCKETCLOUD_OAUTH_KEY"] &&
       !process.env["DANGER_BITBUCKETCLOUD_USERNAME"] &&
       !process.env["DANGER_BITBUCKETCLOUD_REPO_ACCESSTOKEN"] &&
-      !gitLabApiCredentials.token &&
-      !gitLabApiCredentials.oauthToken
+      !process.env["DANGER_GITLAB_API_TOKEN"] &&
+      !process.env["DANGER_GITLAB_API_OAUTH_TOKEN"]
     ) {
       log("")
       log(
@@ -74,7 +72,7 @@ if (program.args.length === 0) {
   process.exitCode = 1
 } else {
   const customHost =
-    process.env["DANGER_GITHUB_HOST"] || process.env["DANGER_BITBUCKETSERVER_HOST"] || gitLabApiCredentials.host // this defaults to https://gitlab.com
+    process.env["DANGER_GITHUB_HOST"] || process.env["DANGER_BITBUCKETSERVER_HOST"] || getGitLabHostFromEnv(process.env) // This defaults to https://www.gitlab.com
 
   // Allow an ambiguous amount of args to find the PR reference
   const findPR = program.args.find((a) => a.includes(customHost) || a.includes("github") || a.includes("bitbucket.org"))