Clarification required on pull request initiation

[PrajinIr]

Hex20, based in India is focusing on building Cube-Sats.
We have a cube-satellite Nila which is expected to launch on first week of March this year.
We have developed a decoder for Nila using gr-satellites and is working as expected.

But we have a couple of clarifications required

1. We are expected to get the NORAD ID only after a month. Shall we proceed with a dummy NORAD ID for a pull request?
2. Currently we have updated python/telemetry/init.py and python/telemetry/CMakeLists.txt. We have also added our decoder inside python/telemetry/. It is working as expected. Is it enough from source code perspective?
3. We are planning to add the wavefile inside satellite-recordings folder and modify the test.sh file. Is it enough for module testing mentioned in CONTRIBUTUNG.md?

[daniestevez]

Thanks for your interest in upstreaming this code.

We are expected to get the NORAD ID only after a month. Shall we proceed with a dummy NORAD ID for a pull request?

Typically we use the temporary NORAD ID assigned by SatNOGS until the object is identified post-launch. In this case, I see in SatNOGS DB that you already have the temporary NORAD ID 98737, so this is the one you should use.

Currently we have updated python/telemetry/init.py and python/telemetry/CMakeLists.txt. We have also added our decoder inside python/telemetry/. It is working as expected. Is it enough from source code perspective?

Ideally you should also add a SatYAML file to python/satyaml describing what modulation your satellite is using and referencing your telemetry parser.

We are planning to add the wavefile inside satellite-recordings folder and modify the test.sh file. Is it enough for module testing mentioned in CONTRIBUTUNG.md?

That sounds good. Certainly other satellites have even less testing than this, so demanding a higher test coverage would be unfair.

[PrajinIr]

Thank you daniestevez for your time.
We have already added YAML file to python/satyaml for our satellite. We missed to mention.
So, we are planning to initiate the pull request at the earliest.

[PrajinIr]

We have raised the pull request titled "Hex20 Nila 3U Satellite Decoder ".
It is mentioned in the pull request that all tests have passed.
Please perform the merge action.