Re-enabled the test with a fix to use a fixed 30 days for @monthly in actor deserialization for now (#1530)

Signed-off-by: Whit Waldo <[email protected]>

Author: WhitWaldo

src/Dapr.Actors/Extensions/DurationExtensions.cs

@@ -68,13 +68,12 @@ public static TimeSpan FromPrefixedPeriod(this string period)
 
         if (period.StartsWith(MonthlyPrefixPeriod))
         {
-            var dateTime = DateTime.UtcNow;
-            return dateTime.AddMonths(1) - dateTime;
+            return TimeSpan.FromDays(30);
         }
 
         if (period.StartsWith(MidnightPrefixPeriod))
         {
-            return new TimeSpan();
+            return TimeSpan.Zero;
         }
 
         if (period.StartsWith(WeeklyPrefixPeriod))

src/Dapr.Actors/Runtime/ConverterUtils.cs

@@ -49,7 +49,7 @@ public static TimeSpan ConvertTimeSpanFromDaprFormat(string valueString)
         int msIndex = spanOfValue.IndexOf("ms");
 
         // handle days from hours.
-        var hoursSpan = spanOfValue.Slice(0, hIndex);
+        var hoursSpan = spanOfValue[..hIndex];
         var hours = int.Parse(hoursSpan);
         var days = hours / 24;
         hours %= 24;

test/Dapr.Actors.Test/Runtime/ActorManagerTests.cs

@@ -219,19 +219,19 @@ public async Task DeserializeTimer_Period_DaprFormat_Every2()
             Assert.Equal(TimeSpan.FromHours(3).Add(TimeSpan.FromMinutes(2)).Add(TimeSpan.FromSeconds(15)), result.Period);
         }
 
-        // [Fact]
-        // public async Task DeserializeTimer_Period_DaprFormat_Monthly()
-        // {
-        //     const string timerJson = "{\"callback\": \"TimerCallback\", \"period\": \"@monthly\"}";
-        //     await using var stream = new MemoryStream(Encoding.UTF8.GetBytes(timerJson));
-        //     var result = await ActorManager.DeserializeAsync(stream);
-        //     
-        //     Assert.Equal("TimerCallback", result.Callback);
-        //     Assert.Equal(Array.Empty<byte>(), result.Data);
-        //     Assert.Null(result.Ttl);
-        //     Assert.Equal(TimeSpan.Zero, result.DueTime);
-        //     Assert.Equal(TimeSpan.FromDays(30), result.Period);
-        // }
+        [Fact]
+        public async Task DeserializeTimer_Period_DaprFormat_Monthly()
+        {
+            const string timerJson = "{\"callback\": \"TimerCallback\", \"period\": \"@monthly\"}";
+            await using var stream = new MemoryStream(Encoding.UTF8.GetBytes(timerJson));
+            var result = await ActorManager.DeserializeAsync(stream);
+            
+            Assert.Equal("TimerCallback", result.Callback);
+            Assert.Equal(Array.Empty<byte>(), result.Data);
+            Assert.Null(result.Ttl);
+            Assert.Equal(TimeSpan.Zero, result.DueTime);
+            Assert.Equal(TimeSpan.FromDays(30), result.Period);
+        }
 
         [Fact]
         public async Task DeserializeTimer_Period_DaprFormat_Weekly()