Skip to content

Commit f5ea13a

Browse files
authored
Fix Dart2JS adding extraneous sourcemaps to its archive when both wasm and js are enabled. (#4267)
1 parent ae83526 commit f5ea13a

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

build_web_compilers/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
## 4.3.2
2+
- Fix Dart2JS adding extraneous sourcemaps to its archive when both wasm and js are enabled.
3+
14
## 4.3.1
25
- Fix Dart2JS sourcemaps not being written when both wasm and js are enabled.
36

build_web_compilers/lib/src/dart2js_bootstrap.dart

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,11 @@ $librariesString
131131
final archive = Archive();
132132
await for (final jsFile in fileGlob.list(root: rootDir)) {
133133
if (jsFile.path.endsWith(entrypointExtension) ||
134-
jsFile.path.endsWith(jsEntrypointSourceMapExtension)) {
134+
jsFile.path.endsWith(
135+
onlyCompiler
136+
? jsEntrypointSourceMapExtension
137+
: dart2jsEntrypointSourceMapExtension,
138+
)) {
135139
// These are explicitly output, and are not part of the archive.
136140
continue;
137141
}

build_web_compilers/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: build_web_compilers
2-
version: 4.3.1
2+
version: 4.3.2
33
description: Builder implementations wrapping the dart2js and DDC compilers.
44
repository: https://github.com/dart-lang/build/tree/master/build_web_compilers
55
resolution: workspace

0 commit comments

Comments
 (0)