Skip to content

Commit 60a263d

Browse files
committed
Handle BitArray.setRange assertion better.
1 parent b4eaeb2 commit 60a263d

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

app/lib/search/mem_index.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ class InMemoryPackageIndex {
132132

133133
PackageSearchResult search(ServiceSearchQuery query) {
134134
// prevent any work if offset is outside of the range
135-
if ((query.offset ?? 0) > _documents.length) {
135+
if ((query.offset ?? 0) >= _documents.length) {
136136
return PackageSearchResult.empty();
137137
}
138138
return _scorePool.withScore(

app/test/search/mem_index_test.dart

+6
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,12 @@ server.dart adds a small, prescriptive server (PicoServer) that can be configure
8989
index = InMemoryPackageIndex(documents: docs);
9090
});
9191

92+
test('empty index search', () {
93+
final index = InMemoryPackageIndex(documents: []);
94+
final rs = index.search(ServiceSearchQuery.parse(query: 'text'));
95+
expect(rs.packageHits, isEmpty);
96+
});
97+
9298
test('package name match: async', () async {
9399
final PackageSearchResult result =
94100
index.search(ServiceSearchQuery.parse(query: 'async'));

0 commit comments

Comments
 (0)