fix: more fixes for performance-move-const-arg clang-tidy

Author: knst

src/evo/deterministicmns.cpp

@@ -1836,7 +1836,7 @@ std::vector<std::pair<uint256, CDeterministicMNListDiff>> CDeterministicMNManage
             temp_diffs.emplace_back(pIndex->GetBlockHash(), recalc_diff);
 
             // Move forward
-            current_list = std::move(next_list);
+            current_list = next_list; // TODO: make CDeterministicMNList moveable
         }
 
         // Verify that applying all diffs results in the target snapshot

src/instantsend/net_instantsend.cpp

@@ -237,11 +237,11 @@ void NetInstantSend::ProcessPendingISLocks(std::vector<std::pair<uint256, instan
         still_pending.reserve(bad_is_locks.size());
         for (auto& p : locks_to_process) {
             if (bad_is_locks.contains(p.first)) {
-                still_pending.push_back(std::move(p));
+                still_pending.emplace_back(std::move(p));
             }
         }
         // Now check against the previous active set and perform banning if this fails
-        ProcessPendingInstantSendLocks(llmq_params, dkgInterval, /*ban=*/true, std::move(still_pending));
+        ProcessPendingInstantSendLocks(llmq_params, dkgInterval, /*ban=*/true, still_pending);
     }
 }
 

src/masternode/meta.cpp

@@ -202,7 +202,7 @@ bool CMasternodeMetaMan::SetPlatformBan(const uint256& inv_hash, PlatformBanMess
 
     bool ret = GetMetaInfo(protx_hash).SetPlatformBan(true, ban_msg.m_requested_height);
     if (ret) {
-        m_seen_platform_bans.insert(inv_hash, std::move(ban_msg));
+        m_seen_platform_bans.emplace(inv_hash, std::move(ban_msg));
     }
     return ret;
 }