Merge #6980: backport: bitcoin#24419, bitcoin#25351, bitcoin#25466, bitcoin#25701, bitcoin#25707, bitcoin#25733, bitcoin#25872, bitcoin#31364, bitcoin#31305, bitcoin#31051, partial bitcoin#31306

001493a fix: more fixes for performance-move-const-arg clang-tidy (Konstantin Akimov)
245d1b1 fix: more fixes for bugprone-use-after-move clang-tidy (Konstantin Akimov)
022896e fix: more fixes for performance-unnecessary-copy-initialization due to newer clang 19 (Konstantin Akimov)
36d589a partial Merge bitcoin#31306: ci: Update Clang in "tidy" job (merge-script)
828b9bc Merge bitcoin#31051: test: remove unused code from `script_tests` (merge-script)
b33214c Merge bitcoin#31305: refactor: Fix remaining clang-tidy performance-inefficient-vector errors (Ava Chow)
4734a59 Merge bitcoin#31364: refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors (Ava Chow)
fdddfc1 Merge bitcoin#25872: Fix issues when calling std::move(const&) (fanquake)
887d7b3 Merge bitcoin#25701: fix comment spellings from the codespell lint (fanquake)
0e7d0e2 partial Merge bitcoin#25707: refactor: Make const references to avoid unnecessarily copying objects and enable two clang-tidy checks (MacroFake)
03a8a7e Merge bitcoin#25733: tidy: enable bugprone-use-after-move (MacroFake)
3538700 Merge bitcoin#25466: ci: add unused-using-decls to clang-tidy (MacroFake)
f89f8a1 Merge bitcoin#25351: rpc, wallet: Scan mempool after import* - Second attempt (Andrew Chow)
b78bf3e Merge bitcoin#24419: lint: remove no-longer used exceptions from lint-format-strings.py (MarcoFalke)

Pull request description:

  ## What was done?
  Some more regular backports from Bitcoin Core v24; some extra backports have been pulled from Bitcoin Core v29 to fix clang-tidy for newer clang-19

  ## How Has This Been Tested?
  Run unit & functional tests

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

ACKs for top commit:
  UdjinM6:
    utACK 001493a
  kwvg:
    utACK 001493a

Tree-SHA512: 39927ecc4008aa7602947e3cdb018ba141e0dae3e9f6f7f983411dc24cb6300c0d27e4f5a9128e292a184ef18841f6da640479c78cc8e0c1d1816dc405bc850f

Author: PastaPastaPasta

ci/dash/lint-tidy.sh

@@ -44,6 +44,7 @@ iwyu_tool.py \
   "src/util/moneystr.cpp" \
   "src/util/serfloat.cpp" \
   "src/util/spanparsing.cpp" \
+  "src/util/string.cpp" \
   "src/util/strencodings.cpp" \
   "src/util/syserror.cpp" \
   "src/util/url.cpp" \

contrib/devtools/iwyu/bitcoin.core.imp

@@ -1,3 +1,3 @@
-# Fixups / upstreamed changes
+# Nothing for now.
 [
 ]

src/.clang-tidy

@@ -1,16 +1,28 @@
 Checks: '
 -*,
 bugprone-argument-comment,
+bugprone-use-after-move,
+misc-unused-using-decls,
 modernize-use-default-member-init,
 modernize-use-nullptr,
+performance-for-range-copy,
+performance-move-const-arg,
+performance-unnecessary-copy-initialization,
 readability-const-return-type,
 readability-redundant-declaration,
 readability-redundant-string-init,
 '
 WarningsAsErrors: '
 bugprone-argument-comment,
+bugprone-use-after-move,
+misc-unused-using-decls,
 modernize-use-default-member-init,
 modernize-use-nullptr,
+performance-move-const-arg,
+performance-unnecessary-copy-initialization,
 readability-redundant-declaration,
 readability-redundant-string-init,
 '
+CheckOptions:
+ - key: performance-move-const-arg.CheckTriviallyCopyableMove
+   value: false

src/bench/load_external.cpp

@@ -28,7 +28,7 @@ static void LoadExternalBlockFile(benchmark::Bench& bench)
     // block data) as a stream object.
     const fs::path blkfile{testing_setup.get()->m_path_root / "blk.dat"};
     CDataStream ss(SER_DISK, 0);
-    auto params{Params()};
+    const auto& params{Params()};
     ss << params.MessageStart();
     ss << static_cast<uint32_t>(benchmark::data::block813851.size());
     // We can't use the streaming serialization (ss << benchmark::data::block813851)

src/bench/prevector.cpp

@@ -112,6 +112,7 @@ static void PrevectorFillVectorDirect(benchmark::Bench& bench)
 {
     bench.run([&] {
         std::vector<prevector<28, T>> vec;
+        vec.reserve(260);
         for (size_t i = 0; i < 260; ++i) {
             vec.emplace_back();
         }
@@ -124,6 +125,7 @@ static void PrevectorFillVectorIndirect(benchmark::Bench& bench)
 {
     bench.run([&] {
         std::vector<prevector<28, T>> vec;
+        vec.reserve(260);
         for (size_t i = 0; i < 260; ++i) {
             // force allocation
             vec.emplace_back(29, T{});

src/bench/wallet_loading.cpp

@@ -19,8 +19,6 @@
 using wallet::CWallet;
 using wallet::DatabaseFormat;
 using wallet::DatabaseOptions;
-using wallet::ISMINE_SPENDABLE;
-using wallet::MakeWalletDatabase;
 using wallet::TxStateInactive;
 using wallet::WALLET_FLAG_DESCRIPTORS;
 using wallet::WalletContext;

src/bitcoin-cli.cpp

@@ -948,7 +948,7 @@ static void GetWalletBalances(UniValue& result)
 
     UniValue balances(UniValue::VOBJ);
     for (const UniValue& wallet : wallets.getValues()) {
-        const std::string wallet_name = wallet.get_str();
+        const std::string& wallet_name = wallet.get_str();
         const UniValue getbalances = ConnectAndCallRPC(&rh, "getbalances", /* args=*/{}, wallet_name);
         const UniValue& balance = getbalances.find_value("result")["mine"]["trusted"];
         balances.pushKV(wallet_name, balance);

src/bitcoin-tx.cpp

@@ -279,7 +279,7 @@ static void MutateTxAddOutAddr(CMutableTransaction& tx, const std::string& strIn
     CAmount value = ExtractAndValidateValue(vStrInputParts[0]);
 
     // extract and validate ADDRESS
-    std::string strAddr = vStrInputParts[1];
+    const std::string& strAddr = vStrInputParts[1];
     CTxDestination destination = DecodeDestination(strAddr);
     if (!IsValidDestination(destination)) {
         throw std::runtime_error("invalid TX output address");
@@ -311,7 +311,7 @@ static void MutateTxAddOutPubKey(CMutableTransaction& tx, const std::string& str
     // Extract and validate FLAGS
     bool bScriptHash = false;
     if (vStrInputParts.size() == 3) {
-        std::string flags = vStrInputParts[2];
+        const std::string& flags = vStrInputParts[2];
         bScriptHash = (flags.find('S') != std::string::npos);
     }
 
@@ -363,7 +363,7 @@ static void MutateTxAddOutMultiSig(CMutableTransaction& tx, const std::string& s
     // Extract FLAGS
     bool bScriptHash = false;
     if (vStrInputParts.size() == numkeys + 4) {
-        std::string flags = vStrInputParts.back();
+        const std::string& flags = vStrInputParts.back();
         bScriptHash = (flags.find('S') != std::string::npos);
     }
     else if (vStrInputParts.size() > numkeys + 4) {
@@ -428,13 +428,13 @@ static void MutateTxAddOutScript(CMutableTransaction& tx, const std::string& str
     CAmount value = ExtractAndValidateValue(vStrInputParts[0]);
 
     // extract and validate script
-    std::string strScript = vStrInputParts[1];
+    const std::string& strScript = vStrInputParts[1];
     CScript scriptPubKey = ParseScript(strScript);
 
     // Extract FLAGS
     bool bScriptHash = false;
     if (vStrInputParts.size() == 3) {
-        std::string flags = vStrInputParts.back();
+        const std::string& flags = vStrInputParts.back();
         bScriptHash = (flags.find('S') != std::string::npos);
     }
 
@@ -555,7 +555,7 @@ static void MutateTxSign(CMutableTransaction& tx, const std::string& flagStr)
     UniValue prevtxsObj = registers["prevtxs"];
     {
         for (unsigned int previdx = 0; previdx < prevtxsObj.size(); previdx++) {
-            UniValue prevOut = prevtxsObj[previdx];
+            const UniValue& prevOut = prevtxsObj[previdx];
             if (!prevOut.isObject())
                 throw std::runtime_error("expected prevtxs internal object");
 

src/blockfilter.cpp

@@ -170,7 +170,7 @@ const std::set<BlockFilterType>& AllBlockFilterTypes()
 
     static std::once_flag flag;
     std::call_once(flag, []() {
-            for (auto entry : g_filter_types) {
+            for (const auto& entry : g_filter_types) {
                 types.insert(entry.first);
             }
         });

src/bls/bls_worker.cpp

@@ -15,7 +15,7 @@ template <typename T>
 bool VerifyVectorHelper(Span<T> vec)
 {
     std::set<uint256> set;
-    for (auto item : vec) {
+    for (const auto& item : vec) {
         if (!item.IsValid())
             return false;
         // check duplicates