fix: more fixes for performance-move-const-arg clang-tidy

Author: knst

src/evo/deterministicmns.cpp

@@ -1836,7 +1836,7 @@ std::vector<std::pair<uint256, CDeterministicMNListDiff>> CDeterministicMNManage
             temp_diffs.emplace_back(pIndex->GetBlockHash(), recalc_diff);
 
             // Move forward
-            current_list = std::move(next_list);
+            current_list = next_list; // TODO: make CDeterministicMNList moveable
         }
 
         // Verify that applying all diffs results in the target snapshot

src/instantsend/net_instantsend.cpp

@@ -218,7 +218,7 @@ Uint256HashSet NetInstantSend::ProcessPendingInstantSendLocks(
 }
 
 
-void NetInstantSend::ProcessPendingISLocks(std::vector<std::pair<uint256, instantsend::PendingISLockFromPeer>>&& locks_to_process)
+void NetInstantSend::ProcessPendingISLocks(const std::vector<std::pair<uint256, instantsend::PendingISLockFromPeer>>& locks_to_process)
 {
     // TODO Investigate if leaving this is ok
     auto llmqType = Params().GetConsensus().llmqTypeDIP0024InstantSend;
@@ -241,7 +241,7 @@ void NetInstantSend::ProcessPendingISLocks(std::vector<std::pair<uint256, instan
             }
         }
         // Now check against the previous active set and perform banning if this fails
-        ProcessPendingInstantSendLocks(llmq_params, dkgInterval, /*ban=*/true, std::move(still_pending));
+        ProcessPendingInstantSendLocks(llmq_params, dkgInterval, /*ban=*/true, still_pending);
     }
 }
 
@@ -251,9 +251,9 @@ void NetInstantSend::WorkThreadMain()
         bool fMoreWork = [&]() -> bool {
             if (!m_is_manager.IsInstantSendEnabled()) return false;
 
-            auto [more_work, locks] = m_is_manager.FetchPendingLocks();
+            const auto [more_work, locks] = m_is_manager.FetchPendingLocks();
             if (!locks.empty()) {
-                ProcessPendingISLocks(std::move(locks));
+                ProcessPendingISLocks(locks);
             }
             if (auto signer = m_is_manager.Signer(); signer) {
                 signer->ProcessPendingRetryLockTxs(m_is_manager.PrepareTxToRetry());

src/instantsend/net_instantsend.h

@@ -40,7 +40,7 @@ class NetInstantSend final : public NetHandler
     void WorkThreadMain();
 
 private:
-    void ProcessPendingISLocks(std::vector<std::pair<uint256, instantsend::PendingISLockFromPeer>>&& locks_to_process);
+    void ProcessPendingISLocks(const std::vector<std::pair<uint256, instantsend::PendingISLockFromPeer>>& locks_to_process);
 
     Uint256HashSet ProcessPendingInstantSendLocks(
         const Consensus::LLMQParams& llmq_params, int signOffset, bool ban,

src/masternode/meta.cpp

@@ -202,7 +202,7 @@ bool CMasternodeMetaMan::SetPlatformBan(const uint256& inv_hash, PlatformBanMess
 
     bool ret = GetMetaInfo(protx_hash).SetPlatformBan(true, ban_msg.m_requested_height);
     if (ret) {
-        m_seen_platform_bans.insert(inv_hash, std::move(ban_msg));
+        m_seen_platform_bans.emplace(inv_hash, std::move(ban_msg));
     }
     return ret;
 }