refactor: move verification progress log out of VerifySnapshotPair

Author: UdjinM6

src/evo/deterministicmns.cpp

@@ -1661,8 +1661,14 @@ CDeterministicMNManager::RecalcDiffsResult CDeterministicMNManager::RecalculateA
             return result;
         }
 
+        // Log progress periodically (every 100 snapshot pairs) to avoid spam
+        if (i % 100 == 0) {
+            LogPrintf("CDeterministicMNManager::%s -- Progress: verifying snapshot pair %d/%d (heights %d-%d)\n",
+                      __func__, i + 1, snapshot_blocks.size() - 1, from_index->nHeight, to_index->nHeight);
+        }
+
         // Verify this snapshot pair
-        bool is_snapshot_pair_valid = VerifySnapshotPair(from_index, to_index, from_snapshot, to_snapshot, result, i, snapshot_blocks.size() - 1);
+        bool is_snapshot_pair_valid = VerifySnapshotPair(from_index, to_index, from_snapshot, to_snapshot, result);
 
         // If repair mode is enabled and verification failed, recalculate diffs from blockchain
         if (repair && !is_snapshot_pair_valid) {
@@ -1739,16 +1745,10 @@ std::vector<const CBlockIndex*> CDeterministicMNManager::CollectSnapshotBlocks(
 
 bool CDeterministicMNManager::VerifySnapshotPair(
     const CBlockIndex* from_index, const CBlockIndex* to_index, const CDeterministicMNList& from_snapshot,
-    const CDeterministicMNList& to_snapshot, RecalcDiffsResult& result, size_t pair_index, size_t total_pairs)
+    const CDeterministicMNList& to_snapshot, RecalcDiffsResult& result)
 {
     AssertLockHeld(::cs_main);
 
-    // Log progress periodically (every 100 snapshot pairs) to avoid spam
-    if (pair_index % 100 == 0) {
-        LogPrintf("CDeterministicMNManager::%s -- Progress: verifying snapshot pair %d/%d (heights %d-%d)\n",
-                  __func__, pair_index + 1, total_pairs, from_index->nHeight, to_index->nHeight);
-    }
-
     // Verify this snapshot pair by applying all stored diffs sequentially
     CDeterministicMNList test_list = from_snapshot;
 

src/evo/deterministicmns.h

@@ -757,8 +757,8 @@ class CDeterministicMNManager
     std::vector<const CBlockIndex*> CollectSnapshotBlocks(const CBlockIndex* start_index, const CBlockIndex* stop_index,
                                                            const Consensus::Params& consensus_params) EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
     bool VerifySnapshotPair(const CBlockIndex* from_index, const CBlockIndex* to_index, const CDeterministicMNList& from_snapshot,
-                            const CDeterministicMNList& to_snapshot, RecalcDiffsResult& result, size_t pair_index,
-                            size_t total_pairs) EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
+                            const CDeterministicMNList& to_snapshot, RecalcDiffsResult& result)
+        EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
     std::vector<std::pair<uint256, CDeterministicMNListDiff>> RepairSnapshotPair(
         const CBlockIndex* from_index, const CBlockIndex* to_index, const CDeterministicMNList& from_snapshot,
         const CDeterministicMNList& to_snapshot, BuildListFromBlockFunc build_list_func, RecalcDiffsResult& result)