Skip to content

Commit f1bf6d5

Browse files
AnkitCLIAbhishekKumar9984
authored andcommitted
e2e fixes
1 parent 5828606 commit f1bf6d5

File tree

6 files changed

+53
-3
lines changed

6 files changed

+53
-3
lines changed

cloudsql-mysql-plugin/src/e2e-test/features/source/CloudMySqlDesignTimeValidation.feature

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,23 @@ Feature: CloudMySql source- Verify CloudMySql source plugin design time validati
192192
| connectionName |
193193
| database |
194194
| referenceName |
195-
| importQuery |
195+
196+
@CloudMySql_Required
197+
Scenario: To verify CloudSQLMySQL source plugin validation error message with blank import query
198+
Given Open Datafusion Project to configure pipeline
199+
When Expand Plugin group in the LHS plugins list: "Source"
200+
When Select plugin: "CloudSQL MySQL" from the plugins list as: "Source"
201+
Then Navigate to the properties page of plugin: "CloudSQL MySQL"
202+
Then Select dropdown plugin property: "select-jdbcPluginName" with option value: "driverName"
203+
Then Select radio button plugin property: "instanceType" with value: "public"
204+
Then Replace input plugin property: "connectionName" with value: "connectionName" for Credentials and Authorization related fields
205+
Then Replace input plugin property: "user" with value: "username" for Credentials and Authorization related fields
206+
Then Replace input plugin property: "password" with value: "password" for Credentials and Authorization related fields
207+
Then Enter input plugin property: "referenceName" with value: "sourceRef"
208+
Then Replace input plugin property: "database" with value: "DatabaseName"
209+
Then Click on the Validate button
210+
Then Verify that the Plugin Property: "importQuery" is displaying an in-line error message: "errorMessageImportQuery"
211+
196212

197213
@CloudMySql_Required
198214
Scenario: To verify CloudSQLMySQL source plugin validation error message with invalid connection name with public instance

cloudsql-mysql-plugin/src/e2e-test/resources/errorMessage.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,4 @@ errorLogsMessageInvalidBoundingQuery=Spark program 'phase-1' failed with error:
2424
errorMessageInvalidPassword=SQL error while getting query schema: Error: Access denied for user
2525
errorMessagePrivateConnectionName=Enter the internal IP address of the Compute Engine VM cloudsql proxy is running on, to connect to a private
2626
errorMessageWithBlankPassword=Exception while trying to validate schema of database table
27+
errorMessageImportQuery=Import Query cannot be null. Please specify the Import Query.

mssql-plugin/src/e2e-test/features/mssql/mssql source/DesignTimeValidation.feature

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,22 @@ Feature: Mssql source- Verify Mssql source plugin design time validation scenari
212212
| jdbcPluginName |
213213
| referenceName |
214214
| database |
215-
| importQuery |
215+
216+
@Mssql_Required
217+
Scenario: To verify MSSQL source plugin validation error message with blank import query
218+
Given Open Datafusion Project to configure pipeline
219+
When Expand Plugin group in the LHS plugins list: "Source"
220+
When Select plugin: "SQL Server" from the plugins list as: "Source"
221+
Then Navigate to the properties page of plugin: "SQL Server"
222+
Then Select dropdown plugin property: "select-jdbcPluginName" with option value: "driverName"
223+
Then Replace input plugin property: "host" with value: "host" for Credentials and Authorization related fields
224+
Then Replace input plugin property: "port" with value: "port" for Credentials and Authorization related fields
225+
Then Replace input plugin property: "user" with value: "username" for Credentials and Authorization related fields
226+
Then Replace input plugin property: "password" with value: "password" for Credentials and Authorization related fields
227+
Then Enter input plugin property: "referenceName" with value: "sourceRef"
228+
Then Replace input plugin property: "database" with value: "databaseName"
229+
Then Click on the Validate button
230+
Then Verify that the Plugin Property: "importQuery" is displaying an in-line error message: "errorMessageImportQuery"
216231

217232
@Mssql_Required
218233
Scenario: Verify the validation error message with missing jdbc plugin name

mssql-plugin/src/e2e-test/resources/errorMessage.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,4 @@ errorMessageInvalidCredentialSource=Spark program 'phase-1' failed with error: S
2424
errorLogsMessageInvalidBoundingQuery=Spark program 'phase-1' failed with error: Stage 'SQL Server' encountered : java.io.IOException: Could not find stored procedure
2525
blank.jdbcPluginName.message=Required property 'jdbcPluginName' has no value.
2626
blank.connection.message=Exception while trying to validate schema of database table
27+
errorMessageImportQuery=Import Query cannot be null. Please specify the Import Query.

oracle-plugin/src/e2e-test/features/source/OracleDesignTimeValidation.feature

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,23 @@ Feature: Oracle source- Verify Oracle source plugin design time validation scena
2727
| jdbcPluginName |
2828
| database |
2929
| referenceName |
30-
| importQuery |
30+
31+
Scenario: To verify Oracle source plugin validation error message with blank import query
32+
Given Open Datafusion Project to configure pipeline
33+
When Expand Plugin group in the LHS plugins list: "Source"
34+
When Select plugin: "Oracle" from the plugins list as: "Source"
35+
Then Navigate to the properties page of plugin: "Oracle"
36+
Then Select dropdown plugin property: "select-jdbcPluginName" with option value: "driverName"
37+
Then Replace input plugin property: "host" with value: "host" for Credentials and Authorization related fields
38+
Then Replace input plugin property: "port" with value: "port" for Credentials and Authorization related fields
39+
Then Replace input plugin property: "user" with value: "username" for Credentials and Authorization related fields
40+
Then Replace input plugin property: "password" with value: "password" for Credentials and Authorization related fields
41+
Then Select radio button plugin property: "connectionType" with value: "service"
42+
Then Select radio button plugin property: "role" with value: "normal"
43+
Then Enter input plugin property: "referenceName" with value: "sourceRef"
44+
Then Replace input plugin property: "database" with value: "databaseName"
45+
Then Click on the Validate button
46+
Then Verify that the Plugin Property: "importQuery" is displaying an in-line error message: "errorMessageImportQuery"
3147

3248
Scenario: To verify Oracle source plugin validation error message with invalid reference test data
3349
Given Open Datafusion Project to configure pipeline

oracle-plugin/src/e2e-test/resources/errorMessage.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,4 @@ errorLogsMessageInvalidBoundingQuery=Spark program 'phase-1' failed with error:
1919
java.io.IOException: ORA-00936: missing expression . Please check the system logs for more details.
2020
blank.database.message=Required property 'database' has no value.
2121
blank.connection.message=Exception while trying to validate schema of database table
22+
errorMessageImportQuery=Import Query cannot be null. Please specify the Import Query.

0 commit comments

Comments
 (0)