use ethnum

Author: b41sh

Cargo.toml

@@ -27,8 +27,8 @@ rust-version = "1.80"
 
 [dependencies]
 byteorder = "1.5.0"
+ethnum = "1.5.1"
 fast-float2 = "0.2.3"
-i256 = "0.2.2"
 itoa = "1.0"
 jiff = "0.2.8"
 nom = "8.0.0"

src/core/databend/util.rs

@@ -18,7 +18,7 @@ use std::io::Write;
 
 use byteorder::BigEndian;
 use byteorder::WriteBytesExt;
-use i256::i256;
+use ethnum::i256;
 
 use super::constants::*;
 use super::jentry::JEntry;

src/number.rs

@@ -28,7 +28,7 @@ use serde::de::Visitor;
 use serde::ser::Serialize;
 use serde::ser::Serializer;
 
-use i256::i256;
+use ethnum::i256;
 
 #[derive(Debug, Clone)]
 pub struct Decimal128 {
@@ -53,9 +53,8 @@ pub struct Decimal256 {
 
 impl Decimal256 {
     pub fn to_float64(&self) -> f64 {
-        let _div = 10_f64.powi(self.scale as i32);
-        //self.value.to_f64().unwrap() / div
-        todo!()
+        let div = 10_f64.powi(self.scale as i32);
+        self.value.as_f64() / div
     }
 }
 
@@ -197,13 +196,9 @@ impl Number {
                 Ok(Number::Decimal128(neg_dec))
             }
             Number::Decimal256(v) => {
-                let (neg_value, is_overflow) = v.value.overflowing_neg();
-                if is_overflow {
-                    return Err(Error::Message("Decimal256 overflow".to_string()));
-                }
                 let neg_dec = Decimal256 {
                     scale: v.scale,
-                    value: neg_value,
+                    value: v.value * -1,
                 };
                 Ok(Number::Decimal256(neg_dec))
             }
@@ -526,7 +521,7 @@ impl Display for Number {
                 } else {
                     let pow_scale = i256::from(10).pow(v.scale as u32);
                     // -1/10 = 0
-                    if v.value >= i256::from(0) {
+                    if v.value >= 0 {
                         write!(
                             f,
                             "{}.{:0>width$}",