Skip to content

Add datafusion-functions-json #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matthewmturner opened this issue Sep 11, 2024 · 3 comments · Fixed by #143
Closed

Add datafusion-functions-json #130

matthewmturner opened this issue Sep 11, 2024 · 3 comments · Fixed by #143
Assignees
@alamb

Comments

@matthewmturner
Copy link
Collaborator

Add feature for https://github.com/datafusion-contrib/datafusion-functions-json
@alamb
Copy link
Contributor

alamb commented Sep 12, 2024

💯

@alamb alamb self-assigned this Sep 12, 2024
@alamb
Copy link
Contributor

alamb commented Sep 12, 2024

I will plan to try this after I have completed #132

@alamb alamb mentioned this issue Sep 14, 2024
Merged
matthewmturner added a commit that referenced this issue Sep 14, 2024
@alamb @matthewmturner
Implement Extension registration API (#142)
b419d8c 
Last part of
#132
Closes #132

# Rationale
I want to begin working on integration other components (e.g.
#130) and I
want to avoid littering the code with `cfg` flags.

I think after this PR we'll have two `cfg` uses for each extension.
Short of macros this is the best I can come up with

Changes:
1. Pull deltalake and s3 registration into their own module
2. Create a new API for registering extensions
3. Create a list of nice to have APIs upstream in DataFusion

---------

Co-authored-by: Matthew Turner <[email protected]>
@alamb alamb mentioned this issue Sep 15, 2024
Merged
@alamb
Copy link
Contributor

alamb commented Sep 16, 2024

I have a PR ready: #143

It went quite smootly

matthewmturner pushed a commit that referenced this issue Sep 16, 2024
@alamb
Add datafusion-json-functions as optional extension (#143)
64f583a 
Closes #130

Changes:
1. Integrates the functions
https://github.com/datafusion-contrib/datafusion-functions-json
2. Adds some basic testing for these extensions (I need to figure out
how to do something similar for s3 and delta)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alamb alamb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add datafusion-json-functions as optional extension alamb/datafusion-dft
2 participants
@alamb @matthewmturner