feat(ui/ingest): unity-catalog => databricks

- Change newly-creted Databricks recipes to have `type: databricks`
- Support visual RecipeForm for both `databricks` and `unity-catalog` (including
  platform name and link to documentation at the top).

Author: ligfx

datahub-web-react/src/app/ingest/source/IngestionSourceList.tsx

@@ -105,6 +105,17 @@ enum IngestionSourceType {
 
 const DEFAULT_PAGE_SIZE = 25;
 
+const mapSourceTypeAliases = (source) => {
+    if (source) {
+        let { type } = source;
+        if (type === 'unity-catalog') {
+            type = 'databricks';
+        }
+        return { ...source, type };
+    }
+    return undefined;
+};
+
 const removeExecutionsFromIngestionSource = (source) => {
     if (source) {
         return {
@@ -561,7 +572,7 @@ export const IngestionSourceList = ({ showCreateModal, setShowCreateModal }: Pro
                 </PaginationContainer>
             </SourceContainer>
             <IngestionSourceBuilderModal
-                initialState={removeExecutionsFromIngestionSource(focusSource)}
+                initialState={mapSourceTypeAliases(removeExecutionsFromIngestionSource(focusSource))}
                 open={isBuildingSource}
                 onSubmit={onSubmit}
                 onCancel={onCancel}

datahub-web-react/src/app/ingest/source/builder/RecipeForm/constants.ts

@@ -234,12 +234,12 @@ import {
     AZURE,
     BIGQUERY_BETA,
     CSV,
+    DATABRICKS,
     DBT_CLOUD,
     MYSQL,
     OKTA,
     POWER_BI,
     SAC,
-    UNITY_CATALOG,
     VERTICA,
 } from '@app/ingest/source/builder/constants';
 import { BIGQUERY } from '@app/ingest/source/conf/bigquery/bigquery';
@@ -499,7 +499,7 @@ export const RECIPE_FIELDS: RecipeFields = {
         ],
         filterSectionTooltip: 'Include or exclude specific Schemas, Tables and Views from ingestion.',
     },
-    [UNITY_CATALOG]: {
+    [DATABRICKS]: {
         fields: [WORKSPACE_URL, TOKEN],
         filterFields: [
             UNITY_METASTORE_ID_ALLOW,
@@ -616,11 +616,4 @@ export const RECIPE_FIELDS: RecipeFields = {
 
 export const CONNECTORS_WITH_FORM = new Set(Object.keys(RECIPE_FIELDS));
 
-export const CONNECTORS_WITH_TEST_CONNECTION = new Set([
-    SNOWFLAKE,
-    LOOKER,
-    BIGQUERY_BETA,
-    BIGQUERY,
-    UNITY_CATALOG,
-    SAC,
-]);
+export const CONNECTORS_WITH_TEST_CONNECTION = new Set([SNOWFLAKE, LOOKER, BIGQUERY_BETA, BIGQUERY, DATABRICKS, SAC]);

datahub-web-react/src/app/ingest/source/builder/sources.json

@@ -24,12 +24,12 @@
         "recipe": "source: \n    type: snowflake\n    config:\n        account_id: null\n        include_table_lineage: true\n        include_view_lineage: true\n        include_tables: true\n        include_views: true\n        profiling:\n            enabled: true\n            profile_table_level_only: true\n        stateful_ingestion:\n            enabled: true"
     },
     {
-        "urn": "urn:li:dataPlatform:unity-catalog",
-        "name": "unity-catalog",
+        "urn": "urn:li:dataPlatform:databricks",
+        "name": "databricks",
         "displayName": "Databricks",
         "description": "Import Metastores, Schemas, Tables, lineage, queries, and statistics from Databricks Unity Catalog.",
-        "docsUrl": "https://docs.datahub.com/docs/generated/ingestion/sources/databricks/#module-unity-catalog",
-        "recipe": "source:\n    type: unity-catalog\n    config:\n        # Coordinates\n        workspace_url: null\n        include_table_lineage: true\n        include_column_lineage: false\n        stateful_ingestion:\n            enabled: true"
+        "docsUrl": "https://docs.datahub.com/docs/generated/ingestion/sources/databricks/",
+        "recipe": "source:\n    type: databricks\n    config:\n        # Coordinates\n        workspace_url: null\n        include_table_lineage: true\n        include_column_lineage: false\n        stateful_ingestion:\n            enabled: true"
     },
     {
         "urn": "urn:li:dataPlatform:looker",

datahub-web-react/src/app/ingestV2/source/IngestionSourceList.tsx

@@ -116,6 +116,17 @@ export enum IngestionSourceType {
 
 const DEFAULT_PAGE_SIZE = 25;
 
+const mapSourceTypeAliases = (source) => {
+    if (source) {
+        let { type } = source;
+        if (type === 'unity-catalog') {
+            type = 'databricks';
+        }
+        return { ...source, type };
+    }
+    return undefined;
+};
+
 const removeExecutionsFromIngestionSource = (source) => {
     if (source) {
         return {
@@ -691,7 +702,7 @@ export const IngestionSourceList = ({
                 )}
             </SourceContainer>
             <IngestionSourceBuilderModal
-                initialState={removeExecutionsFromIngestionSource(focusSource)}
+                initialState={mapSourceTypeAliases(removeExecutionsFromIngestionSource(focusSource))}
                 open={showCreateModal}
                 onSubmit={onSubmit}
                 onCancel={onCancel}

datahub-web-react/src/app/ingestV2/source/builder/RecipeForm/constants.ts

@@ -233,12 +233,12 @@ import {
 import {
     AZURE,
     CSV,
+    DATABRICKS,
     DBT_CLOUD,
     MYSQL,
     OKTA,
     POWER_BI,
     SAC,
-    UNITY_CATALOG,
     VERTICA,
 } from '@app/ingestV2/source/builder/constants';
 import { BIGQUERY } from '@app/ingestV2/source/conf/bigquery/bigquery';
@@ -471,7 +471,7 @@ export const RECIPE_FIELDS: RecipeFields = {
         ],
         filterSectionTooltip: 'Include or exclude specific Schemas, Tables and Views from ingestion.',
     },
-    [UNITY_CATALOG]: {
+    [DATABRICKS]: {
         fields: [WORKSPACE_URL, TOKEN],
         filterFields: [
             UNITY_METASTORE_ID_ALLOW,

datahub-web-react/src/app/ingestV2/source/builder/sources.json

@@ -24,12 +24,12 @@
         "recipe": "source: \n    type: snowflake\n    config:\n        account_id: null\n        include_table_lineage: true\n        include_view_lineage: true\n        include_tables: true\n        include_views: true\n        profiling:\n            enabled: true\n            profile_table_level_only: true\n        stateful_ingestion:\n            enabled: true"
     },
     {
-        "urn": "urn:li:dataPlatform:unity-catalog",
-        "name": "unity-catalog",
+        "urn": "urn:li:dataPlatform:databricks",
+        "name": "databricks",
         "displayName": "Databricks",
         "description": "Import Metastores, Schemas, Tables, lineage, queries, and statistics from Databricks Unity Catalog.",
-        "docsUrl": "https://docs.datahub.com/docs/generated/ingestion/sources/databricks/#module-unity-catalog",
-        "recipe": "source:\n    type: unity-catalog\n    config:\n        # Coordinates\n        workspace_url: null\n        include_table_lineage: true\n        include_column_lineage: false\n        stateful_ingestion:\n            enabled: true"
+        "docsUrl": "https://docs.datahub.com/docs/generated/ingestion/sources/databricks/",
+        "recipe": "source:\n    type: databricks\n    config:\n        # Coordinates\n        workspace_url: null\n        include_table_lineage: true\n        include_column_lineage: false\n        stateful_ingestion:\n            enabled: true"
     },
     {
         "urn": "urn:li:dataPlatform:looker",